Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189523002: Ignore setNeedsDisplay for SolidColorScrollbarLayer (Closed)

Created:
6 years, 9 months ago by Xianzhu
Modified:
6 years, 9 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Ignore setNeedsDisplay for SolidColorScrollbarLayer Blink assumes that all scrollbar layers need repaint when scrolling. However, SolidColorScrollbarLayer updates itself, without needing to repaint. Ignore setNeedsDisplay for it. BUG=333026 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M cc/layers/solid_color_scrollbar_layer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Xianzhu
6 years, 9 months ago (2014-03-06 23:53:29 UTC) #1
enne (OOO)
lgtm
6 years, 9 months ago (2014-03-06 23:55:49 UTC) #2
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 9 months ago (2014-03-06 23:57:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/189523002/1
6 years, 9 months ago (2014-03-07 00:11:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 02:42:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 02:42:06 UTC) #6
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 9 months ago (2014-03-07 17:31:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/189523002/1
6 years, 9 months ago (2014-03-07 17:32:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/189523002/1
6 years, 9 months ago (2014-03-07 20:19:14 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-08 00:05:32 UTC) #10
Message was sent while issue was closed. 
Change committed as 255720

Powered by Google App Engine
This is Rietveld 408576698