Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: src/counters.h

Issue 1895223004: Reduce bucket count and range for wasm function count, and add "module" to some names. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: add "module" Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/wasm/module-decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/counters.h
diff --git a/src/counters.h b/src/counters.h
index 7c0dff22d5f66ee3c421bd9af3c4000123f7d4b4..d2870c2fd2a95a28751683f43062d9850694fcf6 100644
--- a/src/counters.h
+++ b/src/counters.h
@@ -590,7 +590,7 @@ class RuntimeCallTimerScope {
HR(errors_thrown_per_context, V8.ErrorsThrownPerContext, 0, 200, 20) \
HR(debug_feature_usage, V8.DebugFeatureUsage, 1, 7, 7) \
/* Asm/Wasm. */ \
- HR(wasm_functions_per_module, V8.WasmFunctionsPerModule, 0, 10000, 101)
+ HR(wasm_functions_per_module, V8.WasmFunctionsPerModule, 1, 10000, 51)
Ilya Sherman 2016/04/19 09:01:08 If you're already logging this histogram, then cha
bradn 2016/04/19 22:02:56 Isn't on the branch yet.
#define HISTOGRAM_TIMER_LIST(HT) \
/* Garbage collection timers. */ \
@@ -623,13 +623,14 @@ class RuntimeCallTimerScope {
/* Total compilation time incl. caching/parsing */ \
HT(compile_script, V8.CompileScriptMicroSeconds, 1000000, MICROSECOND) \
/* Asm/Wasm */ \
- HT(wasm_instantiate_time, V8.WasmInstantiateMicroSeconds, 1000000, \
- MICROSECOND) \
+ HT(wasm_instantiate_module_time, V8.WasmInstantiateModuleMicroSeconds, \
+ 1000000, MICROSECOND) \
HT(wasm_decode_module_time, V8.WasmDecodeModuleMicroSeconds, 1000000, \
MICROSECOND) \
HT(wasm_decode_function_time, V8.WasmDecodeFunctionMicroSeconds, 1000000, \
MICROSECOND) \
- HT(wasm_compile_time, V8.WasmCompileMicroSeconds, 1000000, MICROSECOND) \
+ HT(wasm_compile_module_time, V8.WasmCompileModuleMicroSeconds, 1000000, \
+ MICROSECOND) \
HT(wasm_compile_function_time, V8.WasmCompileFunctionMicroSeconds, 1000000, \
MICROSECOND)
@@ -662,16 +663,16 @@ class RuntimeCallTimerScope {
HM(heap_sample_code_space_committed, V8.MemoryHeapSampleCodeSpaceCommitted) \
HM(heap_sample_maximum_committed, V8.MemoryHeapSampleMaximumCommitted)
-#define HISTOGRAM_MEMORY_LIST(HM) \
- HM(memory_heap_committed, V8.MemoryHeapCommitted) \
- HM(memory_heap_used, V8.MemoryHeapUsed) \
- /* Asm/Wasm */ \
- HM(wasm_decode_peak_memory_bytes, V8.WasmDecodePeakMemoryBytes) \
- HM(wasm_compile_function_peak_memory_bytes, \
- V8.WasmCompileFunctionPeakMemoryBytes) \
- HM(wasm_min_mem_pages_count, V8.WasmMinMemPagesCount) \
- HM(wasm_max_mem_pages_count, V8.WasmMaxMemPagesCount) \
- HM(wasm_function_size_bytes, V8.WasmFunctionSizeBytes) \
+#define HISTOGRAM_MEMORY_LIST(HM) \
+ HM(memory_heap_committed, V8.MemoryHeapCommitted) \
+ HM(memory_heap_used, V8.MemoryHeapUsed) \
+ /* Asm/Wasm */ \
+ HM(wasm_decode_module_peak_memory_bytes, V8.WasmDecodeModulePeakMemoryBytes) \
+ HM(wasm_compile_function_peak_memory_bytes, \
+ V8.WasmCompileFunctionPeakMemoryBytes) \
+ HM(wasm_min_mem_pages_count, V8.WasmMinMemPagesCount) \
+ HM(wasm_max_mem_pages_count, V8.WasmMaxMemPagesCount) \
+ HM(wasm_function_size_bytes, V8.WasmFunctionSizeBytes) \
HM(wasm_module_size_bytes, V8.WasmModuleSizeBytes)
// WARNING: STATS_COUNTER_LIST_* is a very large macro that is causing MSVC
« no previous file with comments | « no previous file | src/wasm/module-decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698