Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1895223004: Reduce bucket count and range for wasm function count, and add "module" to some names. (Closed)

Created:
4 years, 8 months ago by bradnelson
Modified:
4 years, 8 months ago
Reviewers:
Ilya Sherman, bradn, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reduce bucket count and range for wasm function count, and add "module" to some names. BUG= https://code.google.com/p/v8/issues/detail?id=4203 BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=575167 TEST=None R=ahaas@chromium.org,isherman@chromium.org LOG=N Committed: https://crrev.com/600ddaee0ea528ba221b5096fbe47f6c283b841f Cr-Commit-Position: refs/heads/master@{#35680}

Patch Set 1 #

Patch Set 2 : add "module" #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M src/counters.h View 1 3 chunks +15 lines, -14 lines 2 comments Download
M src/wasm/module-decoder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-module.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
bradn
4 years, 8 months ago (2016-04-19 04:14:40 UTC) #2
Ilya Sherman
Thanks :) https://codereview.chromium.org/1895223004/diff/20001/src/counters.h File src/counters.h (right): https://codereview.chromium.org/1895223004/diff/20001/src/counters.h#newcode593 src/counters.h:593: HR(wasm_functions_per_module, V8.WasmFunctionsPerModule, 1, 10000, 51) If you're ...
4 years, 8 months ago (2016-04-19 09:01:08 UTC) #4
bradn
https://codereview.chromium.org/1895223004/diff/20001/src/counters.h File src/counters.h (right): https://codereview.chromium.org/1895223004/diff/20001/src/counters.h#newcode593 src/counters.h:593: HR(wasm_functions_per_module, V8.WasmFunctionsPerModule, 1, 10000, 51) On 2016/04/19 09:01:08, Ilya ...
4 years, 8 months ago (2016-04-19 22:02:57 UTC) #5
Ilya Sherman
Okay, LGTM in that case.
4 years, 8 months ago (2016-04-19 23:35:10 UTC) #6
bradn
ahaas, need your owners lg
4 years, 8 months ago (2016-04-19 23:36:29 UTC) #7
ahaas
lgtm Sorry, I forgot to press the button
4 years, 8 months ago (2016-04-20 07:59:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895223004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895223004/20001
4 years, 8 months ago (2016-04-20 23:51:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 00:18:37 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:13:55 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/600ddaee0ea528ba221b5096fbe47f6c283b841f
Cr-Commit-Position: refs/heads/master@{#35680}

Powered by Google App Engine
This is Rietveld 408576698