Reduce bucket count and range for wasm function count, and add "module" to some names.

Reduce bucket count and range for wasm function count, and add "module" to some names.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=575167
TEST=None
R=ahaas@chromium.org,isherman@chromium.org
LOG=N

Committed: https://crrev.com/600ddaee0ea528ba221b5096fbe47f6c283b841f
Cr-Commit-Position: refs/heads/master@{#35680}

[bradn, 2016-04-19 04:14:39]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-04-19 04:25:41]

Description was changed from

==========
Reduce bucket count and range for wasm function count.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=575167
TEST=None
R=ahaas@chromium.org,isherman@chromium.org
LOG=N
==========

to

==========
Reduce bucket count and range for wasm function count, and add "module" to some
names.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=575167
TEST=None
R=ahaas@chromium.org,isherman@chromium.org
LOG=N
==========

[Ilya Sherman, 2016-04-19 09:01:08]

Thanks :)

https://codereview.chromium.org/1895223004/diff/20001/src/counters.h
File src/counters.h (right):

https://codereview.chromium.org/1895223004/diff/20001/src/counters.h#newcode593
src/counters.h:593: HR(wasm_functions_per_module, V8.WasmFunctionsPerModule, 1,
10000, 51)
If you're already logging this histogram, then changing the underlying bucket
count will result in some weird meshing of data that records to 100 buckets vs.
to 50 buckets.  If the histogram has only been live on Canary or Dev builds,
that might be ok, because those builds are not very long-lasting.  OTOH, if the
code has already made it into a branch (and you're not planning to merge to that
branch), then it's going to keep causing confusion indefinitely.  In that case,
I would recommend renaming the histogram while you make this change.

[bradn, 2016-04-19 22:02:57]

https://codereview.chromium.org/1895223004/diff/20001/src/counters.h
File src/counters.h (right):

https://codereview.chromium.org/1895223004/diff/20001/src/counters.h#newcode593
src/counters.h:593: HR(wasm_functions_per_module, V8.WasmFunctionsPerModule, 1,
10000, 51)
On 2016/04/19 09:01:08, Ilya Sherman wrote:
> If you're already logging this histogram, then changing the underlying bucket
> count will result in some weird meshing of data that records to 100 buckets
vs.
> to 50 buckets.  If the histogram has only been live on Canary or Dev builds,
> that might be ok, because those builds are not very long-lasting.  OTOH, if
the
> code has already made it into a branch (and you're not planning to merge to
that
> branch), then it's going to keep causing confusion indefinitely.  In that
case,
> I would recommend renaming the histogram while you make this change.

Isn't on the branch yet.

[Ilya Sherman, 2016-04-19 23:35:10]

Okay, LGTM in that case.

[bradn, 2016-04-19 23:36:29]

ahaas, need your owners lg

[ahaas, 2016-04-20 07:59:42]

lgtm

Sorry, I forgot to press the button

[bradn, 2016-04-20 23:51:54]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2016-04-20 23:51:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1895223004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1895223004/20001

[commit-bot: I haz the power, 2016-04-21 00:18:36]

Description was changed from

==========
Reduce bucket count and range for wasm function count, and add "module" to some
names.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=575167
TEST=None
R=ahaas@chromium.org,isherman@chromium.org
LOG=N
==========

to

==========
Reduce bucket count and range for wasm function count, and add "module" to some
names.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=575167
TEST=None
R=ahaas@chromium.org,isherman@chromium.org
LOG=N
==========

[commit-bot: I haz the power, 2016-04-21 00:18:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:13:53]

Description was changed from

==========
Reduce bucket count and range for wasm function count, and add "module" to some
names.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=575167
TEST=None
R=ahaas@chromium.org,isherman@chromium.org
LOG=N
==========

to

==========
Reduce bucket count and range for wasm function count, and add "module" to some
names.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=575167
TEST=None
R=ahaas@chromium.org,isherman@chromium.org
LOG=N

Committed: https://crrev.com/600ddaee0ea528ba221b5096fbe47f6c283b841f
Cr-Commit-Position: refs/heads/master@{#35680}
==========

[commit-bot: I haz the power, 2016-04-22 19:13:55]

Patchset 2 (id:??) landed as
https://crrev.com/600ddaee0ea528ba221b5096fbe47f6c283b841f
Cr-Commit-Position: refs/heads/master@{#35680}