Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1895223003: Fix GYP configurations on Mac and Windows after DBC patch. (Closed)

Created:
4 years, 8 months ago by Vyacheslav Egorov (Google)
Modified:
4 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix GYP configurations on Mac and Windows after DBC patch. R=srdjan@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/cb63245a4cc975657c76ca45138e3cabdbc35d8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/gyp/configurations_msvs.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gyp/configurations_xcode.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
4 years, 8 months ago (2016-04-18 22:05:33 UTC) #1
srdjan
lgtm
4 years, 8 months ago (2016-04-18 22:06:35 UTC) #2
Vyacheslav Egorov (Google)
4 years, 8 months ago (2016-04-18 22:07:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cb63245a4cc975657c76ca45138e3cabdbc35d8a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698