Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1895213002: [Extensions UI Mac] Delete the overflow container when the menu closes (Closed)

Created:
4 years, 8 months ago by Devlin
Modified:
4 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions UI Mac] Delete the overflow container when the menu closes Cocoa menus aren't entirely cleaned up when the menu closes (the controller persists across opens/closes), but the views are removed. Explicitly delete the BrowserActionsController from the app menu when the menu closes to prevent it from using a non-existent view. BUG=604355 Committed: https://crrev.com/85d435654b3a9786996c8a67e12185c0a5346652 Cr-Commit-Position: refs/heads/master@{#388023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Devlin
Another one for you, Robert.
4 years, 8 months ago (2016-04-18 19:09:34 UTC) #2
Robert Sesek
LGTM
4 years, 8 months ago (2016-04-18 20:51:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895213002/1
4 years, 8 months ago (2016-04-18 21:02:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 21:08:48 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 21:10:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85d435654b3a9786996c8a67e12185c0a5346652
Cr-Commit-Position: refs/heads/master@{#388023}

Powered by Google App Engine
This is Rietveld 408576698