Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: ui/views/widget/widget_unittest.cc

Issue 1895203004: Update sundry BubbleDelegateView references to BubbleDialogDelegateView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: relative ps Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/widget_unittest.cc
diff --git a/ui/views/widget/widget_unittest.cc b/ui/views/widget/widget_unittest.cc
index ebadeb25d9aabc9818327e4a652db928f27eea60..2596e81915c17d4fa0cc043b1cd68dd4878b0006 100644
--- a/ui/views/widget/widget_unittest.cc
+++ b/ui/views/widget/widget_unittest.cc
@@ -21,7 +21,7 @@
#include "ui/events/test/event_generator.h"
#include "ui/gfx/geometry/point.h"
#include "ui/gfx/native_widget_types.h"
-#include "ui/views/bubble/bubble_delegate.h"
+#include "ui/views/bubble/bubble_dialog_delegate.h"
#include "ui/views/controls/textfield/textfield.h"
#include "ui/views/test/native_widget_factory.h"
#include "ui/views/test/test_views.h"
@@ -67,6 +67,16 @@ struct WidgetCloser {
inline void operator()(Widget* widget) const { widget->CloseNow(); }
};
+class SimpleBubbleView : public BubbleDialogDelegateView {
msw 2016/04/19 18:14:55 ditto q, or why not just use TestBubbleDialogDeleg
Evan Stade 2016/04/19 21:51:32 Done.
+ public:
+ SimpleBubbleView(View* anchor)
+ : BubbleDialogDelegateView(anchor, BubbleBorder::NONE) {}
+ ~SimpleBubbleView() override {}
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(SimpleBubbleView);
+};
+
using WidgetAutoclosePtr = std::unique_ptr<Widget, WidgetCloser>;
} // namespace
@@ -835,11 +845,11 @@ TEST_F(WidgetObserverTest, DestroyBubble) {
WidgetAutoclosePtr anchor(CreateTopLevelPlatformWidget());
anchor->Show();
- BubbleDelegateView* bubble_delegate =
- new BubbleDelegateView(anchor->client_view(), BubbleBorder::NONE);
+ BubbleDialogDelegateView* bubble_delegate =
+ new SimpleBubbleView(anchor->client_view());
{
WidgetAutoclosePtr bubble_widget(
- BubbleDelegateView::CreateBubble(bubble_delegate));
+ BubbleDialogDelegateView::CreateBubble(bubble_delegate));
bubble_widget->Show();
}
@@ -1220,10 +1230,10 @@ TEST_F(WidgetTest, DISABLED_FocusChangesOnBubble) {
EXPECT_TRUE(contents_view->HasFocus());
// Show a bubble.
- BubbleDelegateView* bubble_delegate_view =
- new BubbleDelegateView(contents_view, BubbleBorder::TOP_LEFT);
+ BubbleDialogDelegateView* bubble_delegate_view =
+ new SimpleBubbleView(contents_view);
bubble_delegate_view->SetFocusable(true);
- BubbleDelegateView::CreateBubble(bubble_delegate_view)->Show();
+ BubbleDialogDelegateView::CreateBubble(bubble_delegate_view)->Show();
bubble_delegate_view->RequestFocus();
// |contents_view_| should no longer have focus.
@@ -1236,12 +1246,12 @@ TEST_F(WidgetTest, DISABLED_FocusChangesOnBubble) {
EXPECT_TRUE(contents_view->HasFocus());
}
-class TestBubbleDelegateView : public BubbleDelegateView {
+class TestBubbleDialogDelegateView : public BubbleDialogDelegateView {
public:
- TestBubbleDelegateView(View* anchor)
- : BubbleDelegateView(anchor, BubbleBorder::NONE),
+ TestBubbleDialogDelegateView(View* anchor)
+ : BubbleDialogDelegateView(anchor, BubbleBorder::NONE),
reset_controls_called_(false) {}
- ~TestBubbleDelegateView() override {}
+ ~TestBubbleDialogDelegateView() override {}
bool ShouldShowCloseButton() const override {
reset_controls_called_ = true;
@@ -1256,10 +1266,10 @@ TEST_F(WidgetTest, BubbleControlsResetOnInit) {
anchor->Show();
{
- TestBubbleDelegateView* bubble_delegate =
- new TestBubbleDelegateView(anchor->client_view());
+ TestBubbleDialogDelegateView* bubble_delegate =
+ new TestBubbleDialogDelegateView(anchor->client_view());
WidgetAutoclosePtr bubble_widget(
- BubbleDelegateView::CreateBubble(bubble_delegate));
+ BubbleDialogDelegateView::CreateBubble(bubble_delegate));
EXPECT_TRUE(bubble_delegate->reset_controls_called_);
bubble_widget->Show();
}

Powered by Google App Engine
This is Rietveld 408576698