Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1895203004: Update sundry BubbleDelegateView references to BubbleDialogDelegateView (Closed)

Created:
4 years, 8 months ago by Evan Stade
Modified:
4 years, 8 months ago
Reviewers:
msw, sky
CC:
chromium-reviews, tapted, msw+watch_chromium.org, sadrul, yusukes+watch_chromium.org, tfarina, shuchen+watch_chromium.org, nona+watch_chromium.org, groby+bubble_chromium.org, noyau+watch_chromium.org, rouslan+bubble_chromium.org, oshima+watch_chromium.org, kalyank, hcarmona+bubble_chromium.org, davemoore+watch_chromium.org, Matt Giuca
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update sundry BubbleDelegateView references to BubbleDialogDelegateView BUG=585312 Committed: https://crrev.com/473428b8e5f8752847911a8bbca084cc21bed19c Cr-Commit-Position: refs/heads/master@{#388338}

Patch Set 1 #

Patch Set 2 : relative ps #

Total comments: 6

Patch Set 3 : add comment, reuse existing test class #

Patch Set 4 : relative again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -46 lines) Patch
M ui/views/examples/bubble_example.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M ui/views/examples/examples_main.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/touchui/touch_selection_menu_runner_views.cc View 10 chunks +17 lines, -12 lines 0 comments Download
M ui/views/widget/native_widget_mac_unittest.mm View 1 2 3 chunks +15 lines, -4 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 5 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Evan Stade
+msw for review +sky for OWNERS, review
4 years, 8 months ago (2016-04-19 15:25:01 UTC) #2
sky
LGTM
4 years, 8 months ago (2016-04-19 17:11:41 UTC) #3
msw
https://codereview.chromium.org/1895203004/diff/20001/ui/views/examples/examples_main.cc File ui/views/examples/examples_main.cc (right): https://codereview.chromium.org/1895203004/diff/20001/ui/views/examples/examples_main.cc#newcode92 ui/views/examples/examples_main.cc:92: ui::MaterialDesignController::Initialize(); Why is this needed in this CL? https://codereview.chromium.org/1895203004/diff/20001/ui/views/widget/native_widget_mac_unittest.mm ...
4 years, 8 months ago (2016-04-19 18:14:55 UTC) #4
Evan Stade
https://codereview.chromium.org/1895203004/diff/20001/ui/views/examples/examples_main.cc File ui/views/examples/examples_main.cc (right): https://codereview.chromium.org/1895203004/diff/20001/ui/views/examples/examples_main.cc#newcode92 ui/views/examples/examples_main.cc:92: ui::MaterialDesignController::Initialize(); On 2016/04/19 18:14:55, msw wrote: > Why is ...
4 years, 8 months ago (2016-04-19 21:51:32 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895203004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895203004/60001
4 years, 8 months ago (2016-04-19 21:52:15 UTC) #7
msw
lgtm
4 years, 8 months ago (2016-04-19 22:01:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895203004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895203004/60001
4 years, 8 months ago (2016-04-19 22:45:14 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-19 22:50:07 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:17:26 UTC) #15
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/473428b8e5f8752847911a8bbca084cc21bed19c
Cr-Commit-Position: refs/heads/master@{#388338}

Powered by Google App Engine
This is Rietveld 408576698