Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Issue 1895163002: 🐠 Use the new DeviceUtils.HealthyDevices(device_arg=) in a few scripts (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the new DeviceUtils.HealthyDevices(device_arg=) in a few scripts BUG=none Committed: https://crrev.com/bb574a0099d40f6ce916fd5a2dd2118dbbce7a36 Cr-Commit-Position: refs/heads/master@{#387991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -52 lines) Patch
M build/android/adb_command_line.py View 2 chunks +4 lines, -9 lines 0 comments Download
M build/android/adb_install_apk.py View 2 chunks +3 lines, -8 lines 0 comments Download
M build/android/adb_reverse_forwarder.py View 3 chunks +2 lines, -14 lines 0 comments Download
M build/android/incremental_install/installer.py View 1 chunk +6 lines, -21 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
agrieve
On 2016/04/18 17:36:23, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:mikecase@chromium.org
4 years, 8 months ago (2016-04-18 18:35:49 UTC) #3
jbudorick
let's talk about this API before switching things to it.
4 years, 8 months ago (2016-04-18 18:39:20 UTC) #5
mikecase (-- gone --)
This is way cleaner than before :) lgtm
4 years, 8 months ago (2016-04-18 18:42:42 UTC) #7
jbudorick
On 2016/04/18 18:42:42, mikecase wrote: > This is way cleaner than before :) lgtm yeah, ...
4 years, 8 months ago (2016-04-18 18:43:22 UTC) #8
agrieve
On 2016/04/18 18:43:22, jbudorick wrote: > On 2016/04/18 18:42:42, mikecase wrote: > > This is ...
4 years, 8 months ago (2016-04-18 18:48:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895163002/1
4 years, 8 months ago (2016-04-18 18:49:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 20:02:59 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 20:04:31 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb574a0099d40f6ce916fd5a2dd2118dbbce7a36
Cr-Commit-Position: refs/heads/master@{#387991}

Powered by Google App Engine
This is Rietveld 408576698