Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1895143003: Customize card unmasking prompt (Closed)

Created:
4 years, 8 months ago by please use gerrit instead
Modified:
4 years, 8 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, tfarina, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, android-webview-reviews_chromium.org, sdefresne+watch_chromium.org, Evan Stade
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Customize card unmasking prompt This patch enables switching the card unmasking prompt between two configurations: UNMASK_FOR_AUTOFILL: - Title: "Verify your card" - Instructions: "Enter the 3-digit CVC number from the back of your card." - Confirm button: "Verify" The UNMASK_FOR_AUTOFILL mode is how the unmasking prompt looks today. UNMASK_FOR_PAYMENT_REQUEST: - Title: "Pay with your card" - Instructions: "Enter the 3-digit CVC number from the back of your card for verification." - Confirm button: "Continue" The UNMASK_FOR_PAYMENT_REQUEST mode is needed to support paying with masked server cards in PaymentRequest. BUG=587995 Committed: https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a Cr-Commit-Position: refs/heads/master@{#388368}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Fix some tests #

Total comments: 4

Patch Set 4 : Fix mac compile #

Patch Set 5 : FixUpWindowsStyleLabel+UNMASK_FOR_PAYMENT_REQUEST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -21 lines) Patch
M android_webview/native/aw_autofill_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/native/aw_autofill_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskBridge.java View 2 chunks +10 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_client.h View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/test_autofill_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/test_autofill_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/ui/card_unmask_prompt_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.h View 3 chunks +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc View 1 2 3 4 5 chunks +25 lines, -3 lines 0 comments Download
M components/autofill/core/browser/ui/card_unmask_prompt_controller_impl_unittest.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill_strings.grdp View 2 chunks +13 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.mm View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 28 (10 generated)
please use gerrit instead
jdonnelly@, ptal patch 2 (as the person most familiar with this code). https://codereview.chromium.org/1895143003/diff/1/components/autofill_strings.grdp File components/autofill_strings.grdp ...
4 years, 8 months ago (2016-04-18 18:20:35 UTC) #2
Justin Donnelly
https://codereview.chromium.org/1895143003/diff/40001/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm File chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm (right): https://codereview.chromium.org/1895143003/diff/40001/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm#newcode731 chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:731: [verifylButton_ setTitle:SysUTF16ToNSString(controller->GetOkButtonLabel())] Fix typo: s/verify1Button/verifyButton/ Also, I think you ...
4 years, 8 months ago (2016-04-18 21:46:44 UTC) #3
please use gerrit instead
jdonnelly@ ptal patch 5. https://codereview.chromium.org/1895143003/diff/40001/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm File chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm (right): https://codereview.chromium.org/1895143003/diff/40001/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm#newcode731 chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:731: [verifylButton_ setTitle:SysUTF16ToNSString(controller->GetOkButtonLabel())] On 2016/04/18 21:46:44, ...
4 years, 8 months ago (2016-04-18 22:06:34 UTC) #4
Justin Donnelly
lgtm Would you mind creating a bug and assigning it to me to update the ...
4 years, 8 months ago (2016-04-19 02:33:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895143003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895143003/80001
4 years, 8 months ago (2016-04-19 17:03:39 UTC) #9
please use gerrit instead
On 2016/04/19 02:33:24, Justin Donnelly wrote: > Would you mind creating a bug and assigning ...
4 years, 8 months ago (2016-04-19 17:06:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/170350)
4 years, 8 months ago (2016-04-19 17:11:39 UTC) #12
please use gerrit instead
mathp@, owners ptal components/autofill/. michaelbai@, owners ptal android_webview/. estade@, owners ptal chrome/browser/ui/autofill/ and chrome/browser/ui/views/. tedchoc@, ...
4 years, 8 months ago (2016-04-19 17:20:30 UTC) #14
michaelbai
android_webview LGTM
4 years, 8 months ago (2016-04-19 17:21:52 UTC) #15
Mathieu
components/autofill lgtm
4 years, 8 months ago (2016-04-19 17:24:56 UTC) #16
Ted C
On 2016/04/19 17:24:56, Mathieu Perreault wrote: > components/autofill lgtm chrome/.*android/ - lgtm
4 years, 8 months ago (2016-04-19 17:38:31 UTC) #17
please use gerrit instead
On 2016/04/19 17:20:30, Rouslan wrote: > estade@, owners ptal chrome/browser/ui/autofill/ and chrome/browser/ui/views/. estade@ is ooo, ...
4 years, 8 months ago (2016-04-19 17:51:42 UTC) #19
Nico
lgtm
4 years, 8 months ago (2016-04-19 17:52:15 UTC) #20
Evan Stade
my files lgtm
4 years, 8 months ago (2016-04-19 22:44:22 UTC) #22
Dan Beam
am i still an owner of that? jeez. lgtm
4 years, 8 months ago (2016-04-19 22:46:10 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895143003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895143003/80001
4 years, 8 months ago (2016-04-19 23:08:43 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-20 00:04:34 UTC) #26
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:18:35 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/23c6e824ff2ce54ca4a1c79a2e61163cb928dc6a
Cr-Commit-Position: refs/heads/master@{#388368}

Powered by Google App Engine
This is Rietveld 408576698