Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1895143002: experimental/fiddle -> tools/fiddle (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

experimental/fiddle -> tools/fiddle also, test building fiddle_main.cpp & draw.cpp GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1895143002 Committed: https://skia.googlesource.com/skia/+/f0da138c9500bab765a6ef59d97759d1466c1965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -444 lines) Patch
D experimental/fiddle/.gitignore View 1 chunk +0 lines, -3 lines 0 comments Download
D experimental/fiddle/draw.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
D experimental/fiddle/fiddle_main.h View 1 chunk +0 lines, -34 lines 0 comments Download
D experimental/fiddle/fiddle_main.cpp View 1 chunk +0 lines, -164 lines 0 comments Download
D experimental/fiddle/fiddle_test View 1 chunk +0 lines, -33 lines 0 comments Download
D experimental/fiddle/fiddler.go View 1 chunk +0 lines, -159 lines 0 comments Download
D experimental/fiddle/parse-fiddle-output View 1 chunk +0 lines, -21 lines 0 comments Download
M gyp/tools.gyp View 2 chunks +22 lines, -0 lines 0 comments Download
A + tools/fiddle/.gitignore View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/fiddle/draw.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/fiddle/fiddle_main.h View 1 chunk +12 lines, -1 line 0 comments Download
A + tools/fiddle/fiddle_main.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/fiddle/fiddle_test View 2 chunks +4 lines, -2 lines 0 comments Download
A + tools/fiddle/fiddler.go View 4 chunks +6 lines, -3 lines 0 comments Download
A + tools/fiddle/parse-fiddle-output View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895143002/1
4 years, 8 months ago (2016-04-18 17:14:43 UTC) #3
hal.canary
PTAL
4 years, 8 months ago (2016-04-18 17:14:53 UTC) #5
jcgregorio
lgtm
4 years, 8 months ago (2016-04-18 17:22:51 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 17:24:14 UTC) #8
hal.canary
On 2016/04/18 17:24:14, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 8 months ago (2016-04-18 17:26:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895143002/1
4 years, 8 months ago (2016-04-18 18:48:50 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 18:50:10 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f0da138c9500bab765a6ef59d97759d1466c1965

Powered by Google App Engine
This is Rietveld 408576698