Source/bindings/v8/V8WindowShell.cpp - Issue 189513012: DOMDataStore should be cleared when shutting down worker threads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8WindowShell.cpp

Issue 189513012: DOMDataStore should be cleared when shutting down worker threads (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8WindowShell.cpp

diff --git a/Source/bindings/v8/V8WindowShell.cpp b/Source/bindings/v8/V8WindowShell.cpp

index 17e19be2a8dcf1e1a94c412dbe2a4eec65163c99..51dedc997afb9ec1a4c2900f0ebbc1dfa14f2f3d 100644

--- a/Source/bindings/v8/V8WindowShell.cpp

+++ b/Source/bindings/v8/V8WindowShell.cpp

@@ -286,7 +286,7 @@ void V8WindowShell::createContext()

v8::Handle<v8::Context> context = v8::Context::New(m_isolate, &extensionConfiguration, globalTemplate, m_global.newLocal(m_isolate));

if (context.IsEmpty())

return;

- m_perContextData = V8PerContextData::create(context, m_world.get());

+ m_perContextData = V8PerContextData::create(context, m_world);

double contextCreationDurationInMilliseconds = (currentTime() - contextCreationStartInSeconds) * 1000;

const char* histogramName = "WebCore.V8WindowShell.createContext.MainWorld";