Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189513007: Anchor the high contrast bubble to the app menu. (Closed)

Created:
6 years, 9 months ago by msw
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, James Cook, pkotwicz
Visibility:
Public.

Description

Anchor the high contrast bubble to the app menu. Anchor the bubble to Chrome's app menu; fix the arrow. Only try to show the bubble if the app menu exists. BUG=350508 R=sky@chromium.org TEST=When using the high-contrast-black theme, the chrome bubble shows anchored reasonable. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255855

Patch Set 1 : Anchor the high contrast bubble to the app menu. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M chrome/browser/ui/views/accessibility/invert_bubble_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/accessibility/invert_bubble_view.cc View 5 chunks +8 lines, -14 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
msw
Hey Scott, please take a look; thanks!
6 years, 9 months ago (2014-03-07 23:36:48 UTC) #1
sky
LGTM
6 years, 9 months ago (2014-03-07 23:48:25 UTC) #2
msw
The CQ bit was checked by msw@chromium.org
6 years, 9 months ago (2014-03-07 23:55:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/189513007/20001
6 years, 9 months ago (2014-03-07 23:58:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/189513007/20001
6 years, 9 months ago (2014-03-08 11:12:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 13:52:54 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234327
6 years, 9 months ago (2014-03-08 13:52:55 UTC) #7
msw
The CQ bit was checked by msw@chromium.org
6 years, 9 months ago (2014-03-08 19:44:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/189513007/20001
6 years, 9 months ago (2014-03-08 19:45:13 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 20:26:12 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234559
6 years, 9 months ago (2014-03-08 20:26:12 UTC) #11
msw
The CQ bit was checked by msw@chromium.org
6 years, 9 months ago (2014-03-09 16:56:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/189513007/20001
6 years, 9 months ago (2014-03-09 16:56:47 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 17:23:10 UTC) #14
Message was sent while issue was closed. 
Change committed as 255855

Powered by Google App Engine
This is Rietveld 408576698