Make sure natural_size is set when a frame is cropped.

Make sure natural_size is set when a frame is cropped.
If the natural size is not set, the <video> tag will set its properties videoHeight and videoWidth to the original, uncropped width and height.If that is used for deciding the <video> render size- the aspect ratio will be wrong.

This cl allow setting the natural_size as well as the visible_rect when calling media::VideoFrame::WrapVideoFrame.

BUG=349450
R=fischman@chromium.org, tommi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255839

[perkj_chrome, 2014-03-07 12:32:41]

Hej
I also need to set the natural_size when doing cropping. 

Can you please review?

[tommi (sloooow) - chröme, 2014-03-07 14:45:55]

rs lgtm (counting on Ami to do most of the work :))

[Ami GONE FROM CHROMIUM, 2014-03-07 18:52:06]

LGTM but please add a test that verifies this stuff actually works.  Either a
layouttest or any other kind of end-to-end test that verifies that cropping
happens correctly (ideally a frame that has a thick border in one color, an
offset-from-center interior rectangle filled with another color, and a 1px
border around that interior rect of a third color, and have the test assert the
boundary colors of the resulting cropped frame).

[perkj_chrome, 2014-03-07 22:19:46]

We have WebRtcGetUserMediaBrowserTest TestGetUserMediaAspectRatio that fails if
the aspect ratio is not correct or cropping is done in the wrong place. It is
currently disabled until CC is fixed (currently cropping is not done from the
center of the original image.)

I filed 
code.google.com/p/chromium/issues/detail?id=350538 for extending the test.

[perkj_chrome, 2014-03-07 22:19:46]

We have WebRtcGetUserMediaBrowserTest TestGetUserMediaAspectRatio that fails if
the aspect ratio is not correct or cropping is done in the wrong place. It is
currently disabled until CC is fixed (currently cropping is not done from the
center of the original image.)

I filed 
code.google.com/p/chromium/issues/detail?id=350538 for extending the test.

[perkj_chrome, 2014-03-07 22:20:15]

The CQ bit was checked by perkj@chromium.org

[commit-bot: I haz the power, 2014-03-07 22:23:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/perkj@chromium.org/189513004/1

[commit-bot: I haz the power, 2014-03-07 22:29:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 22:29:16]

Try jobs failed on following builders: linux_chromium_rel, mac_chromium_rel

[perkj_chrome, 2014-03-08 08:08:05]

The CQ bit was checked by perkj@chromium.org

[perkj_chrome, 2014-03-08 08:31:32]

The CQ bit was checked by perkj@chromium.org

[perkj_chrome, 2014-03-08 10:40:45]

The CQ bit was unchecked by perkj@chromium.org

[perkj_chrome, 2014-03-08 10:42:45]

The CQ bit was checked by perkj@chromium.org

[commit-bot: I haz the power, 2014-03-08 11:07:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/perkj@chromium.org/189513004/20001

[commit-bot: I haz the power, 2014-03-08 12:43:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-08 12:43:46]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[perkj_chrome, 2014-03-09 09:17:40]

Committed patchset #2 manually as r255839 (presubmit successful).