Prevent un-parsed LiteralFunction reaching the compiler.

Prevent un-parsed LiteralFunction reaching the compiler.

BUG=chromium:604044
LOG=Y

Committed: https://crrev.com/ed9b7d92e7ddb80e51dd512614261bc3f70e1747
Cr-Commit-Position: refs/heads/master@{#35650}

[vogelheim, 2016-04-19 11:36:39]

Description was changed from

==========
Gracefully handle GetSharedFunctionInfo for an unparsed FunctionLiteral.

BUG=chromium:604044
==========

to

==========
Gracefully handle GetSharedFunctionInfo for an unparsed FunctionLiteral.

BUG=chromium:604044
LOG=Y
==========

[vogelheim, 2016-04-19 14:34:16]

Description was changed from

==========
Gracefully handle GetSharedFunctionInfo for an unparsed FunctionLiteral.

BUG=chromium:604044
LOG=Y
==========

to

==========
Prevent un-parsed LiteralFunction reaching the compiler.

BUG=chromium:604044
LOG=Y
==========

[vogelheim, 2016-04-19 14:43:31]

vogelheim@chromium.org changed reviewers:
+ rossberg@chromium.org

[vogelheim, 2016-04-19 14:43:31]

New theory: The bug actually wasn't in (lazy-)parsing the inner function, but in
lazy-parsing the outer one.

The root cause is that parenthesized_function_ - which is used to determine
lazy/eager parsing - is stored in the parser object, but read & used in
ParseFunctionLiteral. So when we have a FunctionLiteral as default argument, we
have nested ParseFunctionLiteral instances, and the 'inner' instance will
consume the parenthesized_function_ bit meant for the outer one. The solution
here is to simply store it in a local var before parsing the parameters.

[rossberg, 2016-04-19 15:57:37]

On 2016/04/19 14:43:31, vogelheim wrote:
> New theory: The bug actually wasn't in (lazy-)parsing the inner function, but
in
> lazy-parsing the outer one.
> 
> The root cause is that parenthesized_function_ - which is used to determine
> lazy/eager parsing - is stored in the parser object, but read & used in
> ParseFunctionLiteral. So when we have a FunctionLiteral as default argument,
we
> have nested ParseFunctionLiteral instances, and the 'inner' instance will
> consume the parenthesized_function_ bit meant for the outer one. The solution
> here is to simply store it in a local var before parsing the parameters.

Instead of saving & restoring manually, can't you put it into the FunctionState
object?

[vogelheim, 2016-04-19 17:15:26]

On 2016/04/19 15:57:37, rossberg wrote:
> On 2016/04/19 14:43:31, vogelheim wrote:
> > New theory: The bug actually wasn't in (lazy-)parsing the inner function,
but
> in
> > lazy-parsing the outer one.
> > 
> > The root cause is that parenthesized_function_ - which is used to determine
> > lazy/eager parsing - is stored in the parser object, but read & used in
> > ParseFunctionLiteral. So when we have a FunctionLiteral as default argument,
> we
> > have nested ParseFunctionLiteral instances, and the 'inner' instance will
> > consume the parenthesized_function_ bit meant for the outer one. The
solution
> > here is to simply store it in a local var before parsing the parameters.
> 
> Instead of saving & restoring manually, can't you put it into the
FunctionState
> object?

I didn't think of that. It's more code, but arguably easier to follow. Please
have a look at which version you like better.

(Nitpick: In the old version, the flag was never restored. The logic is that the
flag gets 'consumed' by the next functioning following the discovery of the
parenthesis. The new version makes this somewhat clearer, by having a flag for
'next_function_is_*' and 'this_function_is_*'. This way, the state-changing
'consume' operation occurs only in one place, and is managed entirely by the
FunctionState.)

[rossberg, 2016-04-19 17:24:47]

lgtm

[vogelheim, 2016-04-20 09:31:21]

The CQ bit was checked by vogelheim@chromium.org

[vogelheim, 2016-04-20 09:31:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1895123002/#ps100001
(title: "Fix test. (eager_compile_hint used function_state_ of parent
function.)")

[commit-bot: I haz the power, 2016-04-20 09:31:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1895123002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1895123002/100001

[commit-bot: I haz the power, 2016-04-20 09:33:08]

Description was changed from

==========
Prevent un-parsed LiteralFunction reaching the compiler.

BUG=chromium:604044
LOG=Y
==========

to

==========
Prevent un-parsed LiteralFunction reaching the compiler.

BUG=chromium:604044
LOG=Y
==========

[commit-bot: I haz the power, 2016-04-20 09:33:09]

Committed patchset #6 (id:100001)

[nodir1, 2016-04-22 18:43:53]

Description was changed from

==========
Prevent un-parsed LiteralFunction reaching the compiler.

BUG=chromium:604044
LOG=Y
==========

to

==========
Prevent un-parsed LiteralFunction reaching the compiler.

BUG=chromium:604044
LOG=Y

Committed: https://crrev.com/ed9b7d92e7ddb80e51dd512614261bc3f70e1747
Cr-Commit-Position: refs/heads/master@{#35650}
==========

[nodir1, 2016-04-22 18:43:54]

Patchset 6 (id:??) landed as
https://crrev.com/ed9b7d92e7ddb80e51dd512614261bc3f70e1747
Cr-Commit-Position: refs/heads/master@{#35650}