Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 18951003: Skip or delete a bunch of timing out tests. (Closed)

Created:
7 years, 5 months ago by ojan
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Skip or delete a bunch of timing out tests. I tried to CC people to the relevant bugs in the hopes someone will look into them, but in the meantime, these tests are taking up a ridiculous amount of the bot cycle time. In a few cases where the test seemed especially unimportant or unlikely to ever get fixed, I just deleted the test. R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154065

Patch Set 1 #

Patch Set 2 : delete a few more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -385 lines) Patch
M LayoutTests/TestExpectations View 1 10 chunks +15 lines, -35 lines 0 comments Download
D LayoutTests/fast/frames/lots-of-iframes.html View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/fast/frames/lots-of-iframes-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/frames/lots-of-objects.html View 1 chunk +0 lines, -35 lines 0 comments Download
D LayoutTests/fast/frames/lots-of-objects-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/http/tests/plugins/post-url-file.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/http/tests/plugins/post-url-file-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/media/context-menu-actions.html View 1 chunk +0 lines, -91 lines 0 comments Download
D LayoutTests/media/context-menu-actions-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/perf/adding-radio-buttons.html View 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/perf/adding-radio-buttons-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/platform/mac/http/tests/plugins/post-url-file-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/plugins/get-url-with-iframe-target-no-crash.html View 1 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/plugins/get-url-with-iframe-target-no-crash-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/plugins/reloadplugins-and-pages.html View 1 1 chunk +0 lines, -35 lines 0 comments Download
D LayoutTests/plugins/reloadplugins-and-pages-expected.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ojan
7 years, 5 months ago (2013-07-11 23:25:35 UTC) #1
abarth-chromium
Ok. LGTM
7 years, 5 months ago (2013-07-11 23:33:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/18951003/3001
7 years, 5 months ago (2013-07-11 23:36:51 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_python_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=16317
7 years, 5 months ago (2013-07-12 00:15:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/18951003/3001
7 years, 5 months ago (2013-07-12 00:43:46 UTC) #5
ojan
7 years, 5 months ago (2013-07-12 01:18:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r154065 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698