Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1895093002: Create per-descriptor-index LoadApiGetterStub (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Create per-descriptor-index LoadApiGetterStub This avoids custom compilation of receiver handlers for api getters. BUG= Committed: https://crrev.com/473280f82a260f5e07f7ae2649e74732d686389f Cr-Commit-Position: refs/heads/master@{#35616}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -12 lines) Patch
M src/code-factory.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 2 3 2 chunks +28 lines, -3 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 2 3 2 chunks +25 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 1 2 3 2 chunks +9 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
ptal
4 years, 8 months ago (2016-04-18 15:15:53 UTC) #2
Jakob Kummerow
LGTM. Love those platform ports ;-) https://codereview.chromium.org/1895093002/diff/40001/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/1895093002/diff/40001/src/code-stubs.h#newcode146 src/code-stubs.h:146: V(LoadConstant) \ nit: ...
4 years, 8 months ago (2016-04-19 08:17:20 UTC) #3
Toon Verwaest
Addressed comment. @bmeurer: ptal at src/compiler/
4 years, 8 months ago (2016-04-19 09:30:30 UTC) #5
Benedikt Meurer
LGTM on compiler.
4 years, 8 months ago (2016-04-19 10:51:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895093002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895093002/60001
4 years, 8 months ago (2016-04-19 11:46:33 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-19 12:11:12 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 12:12:54 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/473280f82a260f5e07f7ae2649e74732d686389f
Cr-Commit-Position: refs/heads/master@{#35616}

Powered by Google App Engine
This is Rietveld 408576698