Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1895043002: WOFF2: avoid a Msan error use-of-uninitialized-value in woff2_dec.cc (Closed)

Created:
4 years, 8 months ago by Takashi Toyoshima
Modified:
4 years, 8 months ago
Reviewers:
Kunihiko Sakamoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WOFF2: avoid a Msan error use-of-uninitialized-value in woff2_dec.cc Uninitialized buffer is read to obtain x_min value when n_contours is zero, but read value isn't used for the case. So, this isn't real issue at all, but to make the Msan bot feeling happy, fix the logic not to read if n_contours is zero. BUG=602975 Committed: https://crrev.com/988efed96ca86663c64ad8d93e779a3a1c2f1be2 Cr-Commit-Position: refs/heads/master@{#388459}

Patch Set 1 #

Patch Set 2 : update (address upstream review comments) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M third_party/woff2/README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/woff2/src/woff2_dec.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Takashi Toyoshima
let me publish this review request now, but probably you would like to take a ...
4 years, 8 months ago (2016-04-19 08:43:02 UTC) #3
Takashi Toyoshima
FYI, upstream review was finished with changes that are equivalent to the Patch Set 2.
4 years, 8 months ago (2016-04-20 03:54:07 UTC) #4
Kunihiko Sakamoto
lgtm
4 years, 8 months ago (2016-04-20 03:55:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895043002/20001
4 years, 8 months ago (2016-04-20 08:15:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 10:11:10 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:22:08 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/988efed96ca86663c64ad8d93e779a3a1c2f1be2
Cr-Commit-Position: refs/heads/master@{#388459}

Powered by Google App Engine
This is Rietveld 408576698