Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189503002: Use --disable-gpu for virtual/softwarecompositing test suite. (Closed)

Created:
6 years, 9 months ago by danakj
Modified:
6 years, 9 months ago
Reviewers:
jamesr
CC:
blink-reviews, jbauman, aelias_OOO_until_Jul13
Visibility:
Public.

Description

Use --disable-gpu for virtual/softwarecompositing test suite. This will let us remove the --enable-software-compositing and the --disable-gpu-compositing command line flags from chromium. R=jamesr BUG=350141 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168972

Patch Set 1 #

Patch Set 2 : disablegpu: #

Patch Set 3 : disablegpu: #

Patch Set 4 : disablegpu: #

Patch Set 5 : disablegpu: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M LayoutTests/NeverFixTests View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/TestExpectations View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 28 (0 generated)
danakj
6 years, 9 months ago (2014-03-06 23:54:19 UTC) #1
jamesr
lgtm
6 years, 9 months ago (2014-03-07 00:06:13 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-07 16:26:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/189503002/1
6 years, 9 months ago (2014-03-07 16:26:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 16:26:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink, linux_blink_rel, win_blink_rel
6 years, 9 months ago (2014-03-07 16:26:50 UTC) #6
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-07 16:32:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/189503002/1
6 years, 9 months ago (2014-03-07 16:32:23 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 17:19:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel
6 years, 9 months ago (2014-03-07 17:19:40 UTC) #10
danakj
I've added expectations to skip WebGL tests in softwarecompositing.
6 years, 9 months ago (2014-03-07 23:08:57 UTC) #11
danakj
And moved them to NeverFixTests.
6 years, 9 months ago (2014-03-07 23:10:42 UTC) #12
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-11 22:15:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/189503002/50001
6 years, 9 months ago (2014-03-11 22:16:08 UTC) #14
danakj
Plugins should work now, back to the CQ with this
6 years, 9 months ago (2014-03-11 22:16:25 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 23:15:27 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-11 23:15:28 UTC) #17
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-11 23:37:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/189503002/70001
6 years, 9 months ago (2014-03-11 23:37:48 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 23:40:09 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile
6 years, 9 months ago (2014-03-11 23:40:10 UTC) #21
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-11 23:40:38 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/189503002/70001
6 years, 9 months ago (2014-03-11 23:40:45 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 00:18:38 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-12 00:18:39 UTC) #25
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-12 00:20:52 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/189503002/70001
6 years, 9 months ago (2014-03-12 00:21:04 UTC) #27
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 04:14:25 UTC) #28
Message was sent while issue was closed. 
Change committed as 168972

Powered by Google App Engine
This is Rietveld 408576698