Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 1895013003: [turbofan] Fixes to validator (Closed)

Created:
4 years, 8 months ago by Mircea Trofin
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fixes to validator If we have 2 phis with the exact same operand list, and the first phi is used before the second one, via the operand incoming to the block that defines the phi, and the second one's operand is defined (via a parallel move) after the use, then the original operand will be assigned to the first phi. This will lead to a spurious validation error. To fix this, we look at the original pending assessment. Committed: https://crrev.com/7bb766978ba887028c83e37a13e55388c9f53354 Cr-Commit-Position: refs/heads/master@{#35601}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -59 lines) Patch
M src/compiler/register-allocator-verifier.h View 4 chunks +33 lines, -25 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 1 6 chunks +53 lines, -34 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Mircea Trofin
4 years, 8 months ago (2016-04-19 01:25:42 UTC) #3
Benedikt Meurer
4 years, 8 months ago (2016-04-19 04:17:29 UTC) #5
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-19 04:17:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895013003/20001
4 years, 8 months ago (2016-04-19 04:23:08 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 04:25:08 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 04:26:45 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7bb766978ba887028c83e37a13e55388c9f53354
Cr-Commit-Position: refs/heads/master@{#35601}

Powered by Google App Engine
This is Rietveld 408576698