Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1895013002: [wasm] Introduce Encoder::GetLocal and Encoder::SetLocal utilities. (Closed)

Created:
4 years, 8 months ago by titzer
Modified:
4 years, 8 months ago
Reviewers:
bradnelson, aseemgarg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Introduce Encoder::GetLocal and Encoder::SetLocal utilities. R=bradnelson@chromium.org,aseemgarg@chromium.org BUG= Committed: https://crrev.com/37ad3aa9c44aca41fe94c6a71e1dc1c4d6a7ad21 Cr-Commit-Position: refs/heads/master@{#35598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
M src/wasm/asm-wasm-builder.cc View 2 chunks +10 lines, -25 lines 0 comments Download
M src/wasm/encoder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/wasm/encoder.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 8 months ago (2016-04-18 11:38:31 UTC) #1
bradnelson
lgtm
4 years, 8 months ago (2016-04-18 20:31:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895013002/1
4 years, 8 months ago (2016-04-18 20:31:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 20:57:13 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 20:57:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37ad3aa9c44aca41fe94c6a71e1dc1c4d6a7ad21
Cr-Commit-Position: refs/heads/master@{#35598}

Powered by Google App Engine
This is Rietveld 408576698