Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1895003002: Append fragmentainer groups in outer multicols first. (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Append fragmentainer groups in outer multicols first. We need to evaluate the need for extra fragmentainer groups in ancestral multicol containers first, so that the inner ones can calculate their column height restrictions correctly. BUG=572771 Committed: https://crrev.com/5b4232e508495a6986fa2908946d47b045727aa2 Cr-Commit-Position: refs/heads/master@{#388017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -8 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/doubly-nested-with-increasing-row-heights-crash.html View 1 chunk +23 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/multicol/doubly-nested-with-increasing-row-heights-crash-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 2 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-18 20:16:19 UTC) #2
leviw_travelin_and_unemployed
lgtm I'm looking forward to when you have to have quadruply nested multicols in your ...
4 years, 8 months ago (2016-04-18 20:54:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895003002/1
4 years, 8 months ago (2016-04-18 20:54:52 UTC) #5
mstensho (USE GERRIT)
On 2016/04/18 20:54:19, leviw wrote: > lgtm > > I'm looking forward to when you ...
4 years, 8 months ago (2016-04-18 21:01:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 21:01:10 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5b4232e508495a6986fa2908946d47b045727aa2 Cr-Commit-Position: refs/heads/master@{#388017}
4 years, 8 months ago (2016-04-18 21:02:39 UTC) #9
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-19 06:49:33 UTC) #10
Message was sent while issue was closed.
Seems to have fixed bug 604532 too.

Powered by Google App Engine
This is Rietveld 408576698