Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1894993002: Reland of [api] Restrict Template::Set to take templates or primitive values (Closed)

Created:
4 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [api] Restrict Template::Set to take templates or primitive values (patchset #1 id:1 of https://codereview.chromium.org/1860003002/ ) Reason for revert: node.js is updated now Original issue's description: > Revert of [api] Restrict Template::Set to take templates or primitive values (patchset #1 id:1 of https://codereview.chromium.org/1839983002/ ) > > Reason for revert: > Breaks node.js > > Original issue's description: > > [api] Restrict Template::Set to take templates or primitive values > > > > Embedders that passed in non-primitive values should either use > > getters/setters (templates) or install a native data property, > > otherwise, the values would all result in cross-context leaks > > > > BUG=none > > R=verwaest@chromium.org > > LOG=y > > > > Committed: https://crrev.com/eebdee8eafa97849cc70c25f3fecf1b075bac248 > > Cr-Commit-Position: refs/heads/master@{#35244} > > TBR=verwaest@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=none > > Committed: https://crrev.com/e1674a24ca3cb92bb4e58d368b25767bd61a0dfa > Cr-Commit-Position: refs/heads/master@{#35264} TBR=verwaest@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none Committed: https://crrev.com/4de391ef6dd65f8694d2d6d17a41535a4468ba5d Cr-Commit-Position: refs/heads/master@{#35572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M include/v8.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
Created Reland of [api] Restrict Template::Set to take templates or primitive values
4 years, 8 months ago (2016-04-18 10:44:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894993002/1
4 years, 8 months ago (2016-04-18 10:44:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894993002/1
4 years, 8 months ago (2016-04-18 11:02:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 11:08:01 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 11:10:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4de391ef6dd65f8694d2d6d17a41535a4468ba5d
Cr-Commit-Position: refs/heads/master@{#35572}

Powered by Google App Engine
This is Rietveld 408576698