src/compiler/int64-lowering.cc - Issue 1894983002: [turbofan] Introduce CallDescriptorOf helper for safety.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/int64-lowering.cc

Issue 1894983002: [turbofan] Introduce CallDescriptorOf helper for safety. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_issue-4924

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/int64-lowering.cc

diff --git a/src/compiler/int64-lowering.cc b/src/compiler/int64-lowering.cc

index 6a5b87b5a8de303765f32ae59aa96efad78ae0ee..b0962a88dbc62424333380ca472cd2a974440a2d 100644

--- a/src/compiler/int64-lowering.cc

+++ b/src/compiler/int64-lowering.cc

@@ -225,7 +225,7 @@ void Int64Lowering::LowerNode(Node* node) {

case IrOpcode::kCall: {

// TODO(turbofan): Make WASM code const-correct wrt. CallDescriptor.

CallDescriptor* descriptor =

- const_cast<CallDescriptor*>(OpParameter<const CallDescriptor*>(node));

+ const_cast<CallDescriptor*>(CallDescriptorOf(node->op()));

if (DefaultLowering(node) ||

(descriptor->ReturnCount() == 1 &&

descriptor->GetReturnType(0) == MachineType::Int64())) {

« no previous file with comments | « src/compiler/instruction-selector.cc ('k') | src/compiler/linkage.cc » ('j') | no next file with comments »