Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1894973008: Compute bounds union while combining path range draw path batches (Closed)

Created:
4 years, 8 months ago by Kimmo Kinnunen
Modified:
4 years, 8 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org, Chris Dalton
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Compute bounds union while combining path range draw path batches Compute bounds union while combining batches generated by NVPR device independent text code-path. Otherwise the overlap test of the GrDrawTarget::recordBatch violate painter's algorithm order. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1894973008 Committed: https://skia.googlesource.com/skia/+/c4ce72fc15b109c40ad5ba46b06a17209b2a750e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/gpu/batches/GrDrawPathBatch.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Kimmo Kinnunen
4 years, 8 months ago (2016-04-20 09:33:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894973008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894973008/1
4 years, 8 months ago (2016-04-20 09:33:39 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 8 months ago (2016-04-20 09:33:42 UTC) #6
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Please ask for an LGTM from ...
4 years, 8 months ago (2016-04-20 15:33:10 UTC) #8
Kimmo Kinnunen
Brian, any other resident batch reviewers?
4 years, 8 months ago (2016-04-22 07:53:30 UTC) #10
bsalomon
lgtm, sorry missed this one
4 years, 8 months ago (2016-04-22 13:16:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894973008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894973008/1
4 years, 8 months ago (2016-04-25 06:21:59 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 06:35:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c4ce72fc15b109c40ad5ba46b06a17209b2a750e

Powered by Google App Engine
This is Rietveld 408576698