Add HasProperty code stub that tries simple lookups or jumps to runtime otherwise.

Add HasProperty code stub that tries simple lookups or jumps to runtime otherwise.

Code common with ObjectHasOwnProperty builtin was moved to CodeStubAssembler.

BUG=v8:2743
LOG=Y

Committed: https://crrev.com/c89e6eb5725e5c1a613f5aa63c1cb15fb6960534
Cr-Commit-Position: refs/heads/master@{#35972}

[Igor Sheludko, 2016-04-18 12:36:27]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-18 12:36:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894953004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894953004/1

[commit-bot: I haz the power, 2016-04-18 12:38:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 12:38:06]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/4412)
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/296)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/4438)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/4416)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13783)
  v8_win_compile_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/1...)
  v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Igor Sheludko, 2016-04-18 13:00:49]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-04-18 13:03:51]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-04-18 13:08:27]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-18 13:08:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894953004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894953004/40001

[Igor Sheludko, 2016-04-18 13:09:06]

Description was changed from

==========
Add HasProperty stub that tries simple lookups or jumps to runtime otherwise.

Code common with ObjectHasOwnProperty builtin was moved to CodeStubAssembler.
==========

to

==========
Add HasProperty code stub that tries simple lookups or jumps to runtime
otherwise.

Code common with ObjectHasOwnProperty builtin was moved to CodeStubAssembler.
==========

[Igor Sheludko, 2016-04-18 13:11:34]

ishell@chromium.org changed reviewers:
+ jarway@gmail.com, rmcilroy@chromium.org

[Igor Sheludko, 2016-04-18 13:11:35]

Toon, PTAL all.
Ross, PTAL interpreter part.

[Igor Sheludko, 2016-04-18 13:11:55]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org
- jarway@gmail.com

[Igor Sheludko, 2016-04-18 13:12:19]

Toon, PTAL all.
Ross, PTAL interpreter part.

[rmcilroy, 2016-04-18 13:15:40]

Interpreter change LGTM, thanks.

[commit-bot: I haz the power, 2016-04-18 13:32:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 13:32:42]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-04-19 09:00:15]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-04-19 09:00:15]

LGTM on compiler if you use REPLACE_STUB_CALL in JSGenericLowering.

[Igor Sheludko, 2016-04-19 18:07:01]

Description was changed from

==========
Add HasProperty code stub that tries simple lookups or jumps to runtime
otherwise.

Code common with ObjectHasOwnProperty builtin was moved to CodeStubAssembler.
==========

to

==========
Add HasProperty code stub that tries simple lookups or jumps to runtime
otherwise.

Code common with ObjectHasOwnProperty builtin was moved to CodeStubAssembler.

BUG=v8:2743
LOG=Y
==========

[Igor Sheludko, 2016-04-19 18:09:03]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 18:09:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894953004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894953004/60001

[commit-bot: I haz the power, 2016-04-19 18:39:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 18:39:35]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-04-20 10:00:04]

https://codereview.chromium.org/1894953004/diff/40001/src/arm/interface-descr...
File src/arm/interface-descriptors-arm.cc (right):

https://codereview.chromium.org/1894953004/diff/40001/src/arm/interface-descr...
src/arm/interface-descriptors-arm.cc:73: const Register
HasPropertyDescriptor::ObjectRegister() { return r0; }
We're probably at the point where we should just have a generic descriptor that
can give you up to, say 3, registers to use for a descriptor. That way we don't
always need to make these descriptors platform specific. You're likely not
choosing based on a careful profile ;) (Different CL, just an observation)

https://codereview.chromium.org/1894953004/diff/40001/src/full-codegen/s390/f...
File src/full-codegen/s390/full-codegen-s390.cc (right):

https://codereview.chromium.org/1894953004/diff/40001/src/full-codegen/s390/f...
src/full-codegen/s390/full-codegen-s390.cc:457: void
FullCodeGenerator::RestoreContext() {
What about using this helper for the other lines that do it, as useful
side-cleanup?

https://codereview.chromium.org/1894953004/diff/60001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/1894953004/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:996: var_index->Bind(SmiUntag(key));
This should be SmiToWord32 according to Rodolph Perfetta; see his comment in
1843613002

https://codereview.chromium.org/1894953004/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:1003: Label if_iskeyunique(this),
if_iskeynotsymbol(this);
if_iskeyunique is not used anymore

https://codereview.chromium.org/1894953004/diff/60001/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1894953004/diff/60001/src/code-stubs.cc#newco...
src/code-stubs.cc:3928: assembler->Bind(&if_objectisreceiver);
I don't think you need this here. TryToName etc already perform instance type
checks since they only support a subset of the instance types. They will fall
back to the runtime otherwise.

[Igor Sheludko, 2016-04-20 11:40:17]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 11:40:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894953004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894953004/80001

[commit-bot: I haz the power, 2016-04-20 11:41:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 11:41:52]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/4556)
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/434)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/4579)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13905)

[Igor Sheludko, 2016-04-20 12:00:29]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 12:00:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894953004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894953004/100001

[commit-bot: I haz the power, 2016-04-20 12:28:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 12:28:35]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-04-20 13:14:56]

https://codereview.chromium.org/1894953004/diff/40001/src/arm/interface-descr...
File src/arm/interface-descriptors-arm.cc (right):

https://codereview.chromium.org/1894953004/diff/40001/src/arm/interface-descr...
src/arm/interface-descriptors-arm.cc:73: const Register
HasPropertyDescriptor::ObjectRegister() { return r0; }
On 2016/04/20 10:00:04, Toon Verwaest wrote:
> We're probably at the point where we should just have a generic descriptor
that
> can give you up to, say 3, registers to use for a descriptor. That way we
don't
> always need to make these descriptors platform specific. You're likely not
> choosing based on a careful profile ;) (Different CL, just an observation)

Good idea!

https://codereview.chromium.org/1894953004/diff/40001/src/full-codegen/s390/f...
File src/full-codegen/s390/full-codegen-s390.cc (right):

https://codereview.chromium.org/1894953004/diff/40001/src/full-codegen/s390/f...
src/full-codegen/s390/full-codegen-s390.cc:457: void
FullCodeGenerator::RestoreContext() {
On 2016/04/20 10:00:04, Toon Verwaest wrote:
> What about using this helper for the other lines that do it, as useful
> side-cleanup?

Done.

https://codereview.chromium.org/1894953004/diff/60001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/1894953004/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:996: var_index->Bind(SmiUntag(key));
On 2016/04/20 10:00:04, Toon Verwaest wrote:
> This should be SmiToWord32 according to Rodolph Perfetta; see his comment in
> 1843613002

Done.

https://codereview.chromium.org/1894953004/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:1003: Label if_iskeyunique(this),
if_iskeynotsymbol(this);
On 2016/04/20 10:00:04, Toon Verwaest wrote:
> if_iskeyunique is not used anymore

Done.

https://codereview.chromium.org/1894953004/diff/60001/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1894953004/diff/60001/src/code-stubs.cc#newco...
src/code-stubs.cc:3928: assembler->Bind(&if_objectisreceiver);
On 2016/04/20 10:00:04, Toon Verwaest wrote:
> I don't think you need this here. TryToName etc already perform instance type
> checks since they only support a subset of the instance types. They will fall
> back to the runtime otherwise.

I guess you meant TryLookupProperty and TryLookupElement (TryToName checks the
key)? 

Yes we could probably remove this IsReceiver() check now since currently
TryToName does not produce any side effects, but if/when we extend it to do so
we would need to the check back to be spec compliant.

I think it is better to leave it here to avoid hassles in the future.

[Toon Verwaest, 2016-04-21 10:48:11]

lgtm

[Igor Sheludko, 2016-04-21 17:45:15]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-04-21 17:45:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1894953004/#ps100001
(title: "Rebasing")

[commit-bot: I haz the power, 2016-04-21 17:45:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894953004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894953004/100001

[commit-bot: I haz the power, 2016-04-21 17:46:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 17:46:58]

Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/4690)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[Igor Sheludko, 2016-04-26 14:49:09]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 14:49:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894953004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894953004/120001

[commit-bot: I haz the power, 2016-04-26 15:14:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 15:14:06]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-05-03 10:35:20]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-05-03 10:35:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, rmcilroy@chromium.org, verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1894953004/#ps120001
(title: "Rebasing")

[commit-bot: I haz the power, 2016-05-03 10:35:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894953004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894953004/120001

[commit-bot: I haz the power, 2016-05-03 11:11:36]

Description was changed from

==========
Add HasProperty code stub that tries simple lookups or jumps to runtime
otherwise.

Code common with ObjectHasOwnProperty builtin was moved to CodeStubAssembler.

BUG=v8:2743
LOG=Y
==========

to

==========
Add HasProperty code stub that tries simple lookups or jumps to runtime
otherwise.

Code common with ObjectHasOwnProperty builtin was moved to CodeStubAssembler.

BUG=v8:2743
LOG=Y
==========

[commit-bot: I haz the power, 2016-05-03 11:11:38]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-05-03 11:13:16]

Description was changed from

==========
Add HasProperty code stub that tries simple lookups or jumps to runtime
otherwise.

Code common with ObjectHasOwnProperty builtin was moved to CodeStubAssembler.

BUG=v8:2743
LOG=Y
==========

to

==========
Add HasProperty code stub that tries simple lookups or jumps to runtime
otherwise.

Code common with ObjectHasOwnProperty builtin was moved to CodeStubAssembler.

BUG=v8:2743
LOG=Y

Committed: https://crrev.com/c89e6eb5725e5c1a613f5aa63c1cb15fb6960534
Cr-Commit-Position: refs/heads/master@{#35972}
==========

[commit-bot: I haz the power, 2016-05-03 11:13:17]

Patchset 5 (id:??) landed as
https://crrev.com/c89e6eb5725e5c1a613f5aa63c1cb15fb6960534
Cr-Commit-Position: refs/heads/master@{#35972}