third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h - Issue 1894953002: WebFonts: merge fontLoaded() to notifyFinished()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h

Issue 1894953002: WebFonts: merge fontLoaded() to notifyFinished() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review #6 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h

diff --git a/third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h b/third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h

index 63dbecb76fbfe71a93bd505ceffa30951c7e6885..5d916e585dc7b7d88200f3b4ab08249d77af258f 100644

--- a/third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h

+++ b/third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h

@@ -153,9 +153,9 @@ public:

void clear() override { clearResource(); }

- void fontLoaded(FontResource* resource) override

+ void notifyFinished(Resource* resource) override

{

- ASSERT(this->resource() == resource);

+ ASSERT(this->resource() == toFontResource(resource));

triggerEvents(resource);

}

« no previous file with comments | « third_party/WebKit/Source/core/fetch/FontResource.cpp ('k') | no next file » | no next file with comments »