third_party/WebKit/Source/core/fetch/FontResource.h - Issue 1894953002: WebFonts: merge fontLoaded() to notifyFinished()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/FontResource.h

Issue 1894953002: WebFonts: merge fontLoaded() to notifyFinished() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review #6 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/FontResource.h

diff --git a/third_party/WebKit/Source/core/fetch/FontResource.h b/third_party/WebKit/Source/core/fetch/FontResource.h

index b3852f73cc36c7dc626348cf17628abdcd0ea2a2..5b8907fa48dfa0a71cc90933d850f57b3f8994ab 100644

--- a/third_party/WebKit/Source/core/fetch/FontResource.h

+++ b/third_party/WebKit/Source/core/fetch/FontResource.h

@@ -98,7 +98,6 @@ public:

~FontResourceClient() override {}

static bool isExpectedType(ResourceClient* client) { return client->getResourceClientType() == FontType; }

ResourceClientType getResourceClientType() const final { return FontType; }

- virtual void fontLoaded(FontResource*) {}

virtual void fontLoadShortLimitExceeded(FontResource*) {}

virtual void fontLoadLongLimitExceeded(FontResource*) {}

};