Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1894943002: Have pending and active tree use the same space for invalidations (Closed)

Created:
4 years, 8 months ago by yongha78.lee
Modified:
4 years, 8 months ago
Reviewers:
reveman, vmpstr, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have pending and active tree use the same space for invalidations This issue is a tile is removing and creating continually. Pending tree don't create the tile because creating tile use layer rect. On the other hand, when a tile remove from active tree, it uses content rect. So,it removes a tile which don't exist in pending tree. It needs to use same space for creating and removing tile. BUG=601336 R=enne@chromium.org Committed: https://crrev.com/68068222915f5d283e4fed0b865272f6ef05d8ab Cr-Commit-Position: refs/heads/master@{#388116}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -4 lines) Patch
M cc/tiles/picture_layer_tiling.cc View 1 chunk +9 lines, -4 lines 0 comments Download
cc/tiles/picture_layer_tiling_unittest.cc View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
yongha78.lee
Please review this. I have changed codes and comments as enne's review.
4 years, 8 months ago (2016-04-18 05:33:38 UTC) #3
yongha78.lee
Thank you for enne's review. I have changed codes and comments as your guide. But ...
4 years, 8 months ago (2016-04-18 05:52:02 UTC) #4
enne (OOO)
lgtm If you are using the same branch, it should be fine. You can use ...
4 years, 8 months ago (2016-04-18 17:56:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894943002/1
4 years, 8 months ago (2016-04-18 23:39:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 01:37:46 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 01:39:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68068222915f5d283e4fed0b865272f6ef05d8ab
Cr-Commit-Position: refs/heads/master@{#388116}

Powered by Google App Engine
This is Rietveld 408576698