Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1894923002: X87: [Atomics] code stubs for atomic operations. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Atomics] code stubs for atomic operations. port 5e9ddf6ce4b698cb3112bd349ca5206cfada1437 (r35453) original commit message: Reland of (https://codereview.chromium.org/1617503003) * New atomic code stubs for x64, ia32, arm, arm64 * Add convenience functions JumpIfNotValidSmiValue, JumpIfUintNotValidSmiValue to macro-assembler-ia32 (API based on x64 macro assembler) * Remove runtime implementation of Atomics.load, the code stub should always be called instead * Add new test to mjsunit atomics test; check that Smi values of different sizes are supported when possible, else fall back to HeapNumbers These changes were needed to add another codestub: * Bump kStubMajorKeyBits from 7 to 8 * Reduce ScriptContextFieldStub::kSlotIndexBits from 13 to 12 BUG= Committed: https://crrev.com/1ff65e996306c71f7029ad5a3d38250e775e5a2b Cr-Commit-Position: refs/heads/master@{#35560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -0 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +190 lines, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-18 02:41:37 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-18 03:08:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894923002/1
4 years, 8 months ago (2016-04-18 05:48:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 06:06:45 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 06:08:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ff65e996306c71f7029ad5a3d38250e775e5a2b
Cr-Commit-Position: refs/heads/master@{#35560}

Powered by Google App Engine
This is Rietveld 408576698