Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1894903003: Mac: Fix SDK 10.11 Compile errors after clang roll in r387792 (Closed)

Created:
4 years, 8 months ago by tapted
Modified:
4 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, tapted, jennb, Matt Giuca, tfarina, Dmitry Titov, dcheng, noyau+watch_chromium.org, jianli, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Fix SDK 10.11 Compile errors after clang roll in r387792 Looks like the compiler is more strict about method invokations on "`id`- looking" things. E.g., it now enforces method calls on objects of type id<Protocol> to exist on Protocol. BUG=604281 Committed: https://crrev.com/676995d68e8a0164d44ea50ea7185f8a05f4d88e Cr-Commit-Position: refs/heads/master@{#387892}

Patch Set 1 #

Patch Set 2 : fix tests build #

Patch Set 3 : Mock BaseBubbleController #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -41 lines) Patch
M chrome/browser/app_controller_mac.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/app_controller_mac_browsertest.mm View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_node_applescript.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript_test.mm View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/base_bubble_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/chrome_event_processing_window.mm View 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_window.mm View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_window_unittest.mm View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm View 3 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 1 chunk +3 lines, -11 lines 0 comments Download
M ui/views/cocoa/native_widget_mac_nswindow.mm View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tapted
Hi Nico, please take a look. Feel free to CQ it, or to take over ...
4 years, 8 months ago (2016-04-18 08:56:27 UTC) #2
Nico
lgtm Thanks!
4 years, 8 months ago (2016-04-18 11:26:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894903003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894903003/40001
4 years, 8 months ago (2016-04-18 11:26:46 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-18 11:32:38 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 11:35:06 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/676995d68e8a0164d44ea50ea7185f8a05f4d88e
Cr-Commit-Position: refs/heads/master@{#387892}

Powered by Google App Engine
This is Rietveld 408576698