Source/core/dom/Element.idl - Issue 189483004: WontFix: Add fast path for id/name/style/class in getAttribute/setAttribute bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.idl

Issue 189483004: WontFix: Add fast path for id/name/style/class in getAttribute/setAttribute bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add performance tests about rare attribute. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Element.idl

diff --git a/Source/core/dom/Element.idl b/Source/core/dom/Element.idl

index 4a3c23b2a395c50b98071314767ca237a21ebb2e..bfda0b66fd8bd6df47a4b78f62df7fdc420ac896 100644

--- a/Source/core/dom/Element.idl

+++ b/Source/core/dom/Element.idl

@@ -26,8 +26,8 @@

[TreatReturnedNullStringAs=Null, PerWorldBindings] readonly attribute DOMString tagName;

- [TreatReturnedNullStringAs=Null] DOMString getAttribute(DOMString name);

- [RaisesException, CustomElementCallbacks] void setAttribute(DOMString name, DOMString value);

+ [ImplementedAs=bindingsGetAttribute, TreatReturnedNullStringAs=Null] DOMString getAttribute(DOMString name);

+ [ImplementedAs=bindingsSetAttribute, RaisesException, CustomElementCallbacks] void setAttribute(DOMString name, DOMString value);

[CustomElementCallbacks] void removeAttribute(DOMString name);

[MeasureAs=ElementGetAttributeNode] Attr getAttributeNode([Default=Undefined] optional DOMString name); // Removed from DOM4.

[RaisesException, CustomElementCallbacks, MeasureAs=ElementSetAttributeNode] Attr setAttributeNode([Default=Undefined, StrictTypeChecking] optional Attr newAttr); // Removed from DOM4.

« no previous file with comments | « Source/core/dom/Element.cpp ('k') | no next file » | no next file with comments »