PerformanceTests/Bindings/get-attribute-rare.html - Issue 189483004: WontFix: Add fast path for id/name/style/class in getAttribute/setAttribute bindings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: PerformanceTests/Bindings/get-attribute-rare.html

Issue 189483004: WontFix: Add fast path for id/name/style/class in getAttribute/setAttribute bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add performance tests about rare attribute. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body>	3 <body>

4 <div id="foo"></div>	4 <div id="foo" role="group"></div>

5 <script src="../resources/runner.js"></script>	5 <script src="../resources/runner.js"></script>

6 <script>	6 <script>

7 var div = document.getElementById("foo");	7 var div = document.getElementById("foo");

8	8

9 PerfTestRunner.measureRunsPerSecond({	9 PerfTestRunner.measureRunsPerSecond({

10 description: "This benchmark covers 'getAttribute' in Dromaeo/dom-attr.html, and other DOM methods that return a String.",	10 description: "This benchmark covers 'getAttribute' in Dromaeo/dom-attr.html, and other DOM methods that return a String.",

11 run: function() {	11 run: function() {

12 var localDiv = div;	12 var localDiv = div;

13 for (var i = 0; i < 100000; i++)	13 for (var i = 0; i < 100000; i++)

14 localDiv.getAttribute("id");	14 localDiv.getAttribute("role");

15 }});	15 }});

16 </script>	16 </script>

17 </body>	17 </body>

18 </html>	18 </html>

OLD	NEW

« no previous file with comments | « no previous file | PerformanceTests/Bindings/set-attribute-rare.html » ('j') | no next file with comments »