Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 8 months ago by anatoly techtonik Modified:
4 years, 8 months ago Reviewers:
agable, iannucci CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionFix git help on 32-bit Windows
BUG=604018
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=300104
Patch Set 1 #
Total comments: 4
Patch Set 2 : Use OS_BITS to detect docs location #
Created: 4 years, 8 months ago
Messages
Total messages: 13 (3 generated)
Description was changed from ========== Fix git help on 32-bit Windows BUG=604018 ========== to ========== Fix git help on 32-bit Windows BUG=604018 ==========
techtonik@gmail.com changed reviewers: + agable@chromium.org, iannucci@chromium.org
Ready for review.
https://codereview.chromium.org/1894803002/diff/1/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): https://codereview.chromium.org/1894803002/diff/1/bootstrap/win/win_tools.bat... bootstrap/win/win_tools.bat:160: xcopy /i /q /d /y "%WIN_TOOLS_ROOT_DIR%\man\html\*" "%GIT_INST_DIR%\mingw32\share\doc\git-doc" > NUL Don't execute the statement twice, figure out which is the correct mingw directory to use and use that one once.
https://chromiumcodereview.appspot.com/1894803002/diff/1/bootstrap/win/win_to... File bootstrap/win/win_tools.bat (right): https://chromiumcodereview.appspot.com/1894803002/diff/1/bootstrap/win/win_to... bootstrap/win/win_tools.bat:67: reg Query "HKLM\Hardware\Description\System\CentralProcessor\0" | %FIND_EXE% /i "x86" > NUL && (set OS_BITS=32) || (set OS_BITS=64) There's a handy variable OS_BITS here, which will match the mingw\d\d folder below.
PTAL. https://codereview.chromium.org/1894803002/diff/1/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): https://codereview.chromium.org/1894803002/diff/1/bootstrap/win/win_tools.bat... bootstrap/win/win_tools.bat:67: reg Query "HKLM\Hardware\Description\System\CentralProcessor\0" | %FIND_EXE% /i "x86" > NUL && (set OS_BITS=32) || (set OS_BITS=64) On 2016/04/18 22:08:30, iannucci wrote: > There's a handy variable OS_BITS here, which will match the mingw\d\d folder > below. Done. https://codereview.chromium.org/1894803002/diff/1/bootstrap/win/win_tools.bat... bootstrap/win/win_tools.bat:160: xcopy /i /q /d /y "%WIN_TOOLS_ROOT_DIR%\man\html\*" "%GIT_INST_DIR%\mingw32\share\doc\git-doc" > NUL On 2016/04/18 16:04:37, agable wrote: > Don't execute the statement twice, figure out which is the correct mingw > directory to use and use that one once. Done.
I pushed "Publish+Mail Comments". Is there anything else I needed to do?
this looks good to me, but unfortunately the CQ can't handle windows EOLs :/ I can land this manually, however.
Description was changed from ========== Fix git help on 32-bit Windows BUG=604018 ========== to ========== Fix git help on 32-bit Windows BUG=604018 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=300104 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 300104.
Message was sent while issue was closed.
Ah, nuts :/ I set the --author on the commit, but apparently `git cl dcommit` ignores that! :( Sorry!
Message was sent while issue was closed.
On 2016/04/22 06:51:12, iannucci wrote: > Ah, nuts :/ I set the --author on the commit, but apparently `git cl dcommit` > ignores that! :( Sorry! I think it's because depot_tools' source-of-truth is still SVN :/
Message was sent while issue was closed.
On 2016/04/22 06:51:51, iannucci wrote: > On 2016/04/22 06:51:12, iannucci wrote: > > Ah, nuts :/ I set the --author on the commit, but apparently `git cl dcommit` > > ignores that! :( Sorry! > > I think it's because depot_tools' source-of-truth is still SVN :/ No problem. As for EOLs, what is the problem with them? If Git produces patch, it should be able to apply it as well. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
