Fix git help on 32-bit Windows

Fix git help on 32-bit Windows

BUG=604018
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=300104

[anatoly techtonik, 2016-04-16 03:12:57]

Description was changed from

==========
Fix git help on 32-bit Windows

BUG=604018
==========

to

==========
Fix git help on 32-bit Windows

BUG=604018
==========

[anatoly techtonik, 2016-04-16 03:12:57]

techtonik@gmail.com changed reviewers:
+ agable@chromium.org, iannucci@chromium.org

[anatoly techtonik, 2016-04-16 03:14:33]

Ready for review.

[agable, 2016-04-18 16:04:37]

https://codereview.chromium.org/1894803002/diff/1/bootstrap/win/win_tools.bat
File bootstrap/win/win_tools.bat (right):

https://codereview.chromium.org/1894803002/diff/1/bootstrap/win/win_tools.bat...
bootstrap/win/win_tools.bat:160: xcopy /i /q /d /y
"%WIN_TOOLS_ROOT_DIR%\man\html\*" "%GIT_INST_DIR%\mingw32\share\doc\git-doc" >
NUL
Don't execute the statement twice, figure out which is the correct mingw
directory to use and use that one once.

[iannucci, 2016-04-18 22:08:30]

https://chromiumcodereview.appspot.com/1894803002/diff/1/bootstrap/win/win_to...
File bootstrap/win/win_tools.bat (right):

https://chromiumcodereview.appspot.com/1894803002/diff/1/bootstrap/win/win_to...
bootstrap/win/win_tools.bat:67: reg Query
"HKLM\Hardware\Description\System\CentralProcessor\0" | %FIND_EXE% /i "x86" >
NUL && (set OS_BITS=32) || (set OS_BITS=64)
There's a handy variable OS_BITS here, which will match the mingw\d\d folder
below.

[anatoly techtonik, 2016-04-20 03:56:53]

PTAL.

https://codereview.chromium.org/1894803002/diff/1/bootstrap/win/win_tools.bat
File bootstrap/win/win_tools.bat (right):

https://codereview.chromium.org/1894803002/diff/1/bootstrap/win/win_tools.bat...
bootstrap/win/win_tools.bat:67: reg Query
"HKLM\Hardware\Description\System\CentralProcessor\0" | %FIND_EXE% /i "x86" >
NUL && (set OS_BITS=32) || (set OS_BITS=64)
On 2016/04/18 22:08:30, iannucci wrote:
> There's a handy variable OS_BITS here, which will match the mingw\d\d folder
> below.

Done.

https://codereview.chromium.org/1894803002/diff/1/bootstrap/win/win_tools.bat...
bootstrap/win/win_tools.bat:160: xcopy /i /q /d /y
"%WIN_TOOLS_ROOT_DIR%\man\html\*" "%GIT_INST_DIR%\mingw32\share\doc\git-doc" >
NUL
On 2016/04/18 16:04:37, agable wrote:
> Don't execute the statement twice, figure out which is the correct mingw
> directory to use and use that one once.

Done.

[anatoly techtonik, 2016-04-22 06:34:03]

I pushed "Publish+Mail Comments". Is there anything else I needed to do?

[iannucci, 2016-04-22 06:46:45]

this looks good to me, but unfortunately the CQ can't handle windows EOLs :/

I can land this manually, however.

[iannucci, 2016-04-22 06:50:18]

Description was changed from

==========
Fix git help on 32-bit Windows

BUG=604018
==========

to

==========
Fix git help on 32-bit Windows

BUG=604018

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=300104
==========

[iannucci, 2016-04-22 06:50:20]

Committed patchset #2 (id:20001) manually as 300104.

[iannucci, 2016-04-22 06:51:12]

Ah, nuts :/ I set the --author on the commit, but apparently `git cl dcommit`
ignores that! :( Sorry!

[iannucci, 2016-04-22 06:51:51]

On 2016/04/22 06:51:12, iannucci wrote:
> Ah, nuts :/ I set the --author on the commit, but apparently `git cl dcommit`
> ignores that! :( Sorry!

I think it's because depot_tools' source-of-truth is still SVN :/

[anatoly techtonik, 2016-04-22 09:44:00]

On 2016/04/22 06:51:51, iannucci wrote:
> On 2016/04/22 06:51:12, iannucci wrote:
> > Ah, nuts :/ I set the --author on the commit, but apparently `git cl
dcommit`
> > ignores that! :( Sorry!
> 
> I think it's because depot_tools' source-of-truth is still SVN :/

No problem. 

As for EOLs, what is the problem with them? If Git produces patch, it should be
able to apply it as well.