Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 1894723002: [DevTools] Fix console-xpath.html test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-xpath.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 470 matching lines...) Expand 10 before | Expand all | Expand 10 after
481 return this._formatAsAccessorProperty(object, propertyPath.map(prope rty => property.name), false); 481 return this._formatAsAccessorProperty(object, propertyPath.map(prope rty => property.name), false);
482 return this._previewFormatter.renderPropertyPreview(property.type, /** @ type {string} */ (property.subtype), property.value); 482 return this._previewFormatter.renderPropertyPreview(property.type, /** @ type {string} */ (property.subtype), property.value);
483 }, 483 },
484 484
485 /** 485 /**
486 * @param {!WebInspector.RemoteObject} object 486 * @param {!WebInspector.RemoteObject} object
487 * @param {!Element} elem 487 * @param {!Element} elem
488 */ 488 */
489 _formatParameterAsNode: function(object, elem) 489 _formatParameterAsNode: function(object, elem)
490 { 490 {
491 WebInspector.Renderer.renderPromise(object).then(appendRenderer, failedT oRender.bind(this)); 491 WebInspector.Renderer.renderPromise(object).then(appendRenderer.bind(thi s), failedToRender.bind(this));
492 /** 492 /**
493 * @param {!Element} rendererElement 493 * @param {!Element} rendererElement
494 * @this {WebInspector.ConsoleViewMessage}
494 */ 495 */
495 function appendRenderer(rendererElement) 496 function appendRenderer(rendererElement)
496 { 497 {
497 elem.appendChild(rendererElement); 498 elem.appendChild(rendererElement);
499 this._formattedParameterAsNodeForTest();
498 } 500 }
499 501
500 /** 502 /**
501 * @this {WebInspector.ConsoleViewMessage} 503 * @this {WebInspector.ConsoleViewMessage}
502 */ 504 */
503 function failedToRender() 505 function failedToRender()
504 { 506 {
505 this._formatParameterAsObject(object, elem, false); 507 this._formatParameterAsObject(object, elem, false);
506 } 508 }
507 }, 509 },
508 510
511 _formattedParameterAsNodeForTest: function()
512 {
513 },
514
509 /** 515 /**
510 * @param {!WebInspector.RemoteObject} array 516 * @param {!WebInspector.RemoteObject} array
511 * @return {boolean} 517 * @return {boolean}
512 */ 518 */
513 useArrayPreviewInFormatter: function(array) 519 useArrayPreviewInFormatter: function(array)
514 { 520 {
515 return this._message.type !== WebInspector.ConsoleMessage.MessageType.Di rXML; 521 return this._message.type !== WebInspector.ConsoleMessage.MessageType.Di rXML;
516 }, 522 },
517 523
518 /** 524 /**
(...skipping 812 matching lines...) Expand 10 before | Expand all | Expand 10 after
1331 { 1337 {
1332 if (!this._wrapperElement) { 1338 if (!this._wrapperElement) {
1333 WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this ); 1339 WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this );
1334 this._wrapperElement.classList.toggle("collapsed", this._collapsed); 1340 this._wrapperElement.classList.toggle("collapsed", this._collapsed);
1335 } 1341 }
1336 return this._wrapperElement; 1342 return this._wrapperElement;
1337 }, 1343 },
1338 1344
1339 __proto__: WebInspector.ConsoleViewMessage.prototype 1345 __proto__: WebInspector.ConsoleViewMessage.prototype
1340 } 1346 }
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-xpath.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698