Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1894723002: [DevTools] Fix console-xpath.html test (Closed)

Created:
4 years, 8 months ago by kozy
Modified:
4 years, 8 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix console-xpath.html test R=lushnikov@chromium.org Committed: https://crrev.com/c38f3beeeabf6c5613dd6be97b2d1cbc15faa82d Cr-Commit-Position: refs/heads/master@{#388059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-xpath.html View 2 chunks +15 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kozy
please take a look!
4 years, 8 months ago (2016-04-15 23:08:41 UTC) #1
lushnikov
lgtm
4 years, 8 months ago (2016-04-18 21:05:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894723002/1
4 years, 8 months ago (2016-04-18 21:05:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 22:40:55 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 22:41:57 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c38f3beeeabf6c5613dd6be97b2d1cbc15faa82d
Cr-Commit-Position: refs/heads/master@{#388059}

Powered by Google App Engine
This is Rietveld 408576698