tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate - Issue 1894713002: Strong html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate

Issue 1894713002: Strong html (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: ready for review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate b/tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate

index 25510dc856a4f805c76d94ec20583e40ae5b10f6..396ffcda5fbe92e092ab6e8f983e099854d05fd1 100644

--- a/tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate

+++ b/tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate

@@ -10,8 +10,7 @@ $!MEMBERS

// Override default options, since IE returns SelectElement itself and it

// does not operate as a List.

List<OptionElement> get options {

- var options = this.querySelectorAll('option').where(

- (e) => e is OptionElement).toList();

+ var options = new List<OptionElement>.from(this.querySelectorAll('option'));

return new UnmodifiableListView(options);

}