chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRecyclerView.java - Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRecyclerView.java

Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing compilation issues and addressing comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUIState.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRecyclerView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRecyclerView.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRecyclerView.java

index e77b8b8cac4e4ae7c8e662a1d27d5c77e8d17526..aeae8a77a75eb44b1a8bd21b498f733066a97321 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRecyclerView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRecyclerView.java

@@ -128,12 +128,6 @@ public class BookmarkRecyclerView extends RecyclerView implements BookmarkUIObse

}

@Override

- public void onFilterStateSet(BookmarkFilter filter) {

- assert filter == BookmarkFilter.OFFLINE_PAGES;

- scrollToPosition(0);

- }

- @Override

public void onSelectionStateChange(List<BookmarkId> selectedBookmarks) {

if (!mDelegate.isSelectionEnabled()) {

for (int i = 0; i < getLayoutManager().getChildCount(); ++i) {