chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkAddActivity.java - Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkAddActivity.java

Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Marking more methods as visible for testing Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkAddActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkAddActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkAddActivity.java

index 22bc60918f05344b4a5f94cad155a15e526de743..f4cb2890ceb81fcd236f3efa27ac954c081d3a2d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkAddActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkAddActivity.java

@@ -48,8 +48,7 @@ public class BookmarkAddActivity extends AsyncInitializationActivity {

BookmarkId bookmarkId = BookmarkUtils.addBookmarkSilently(

BookmarkAddActivity.this, mModel, title, url);

if (bookmarkId != null) {

- BookmarkUtils.startEditActivity(BookmarkAddActivity.this,

- bookmarkId, null);

+ BookmarkUtils.startEditActivity(BookmarkAddActivity.this, bookmarkId);

}

finish();

}