chrome/android/java/res/values/dimens.xml - Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/values/dimens.xml

Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Marking more methods as visible for testing Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/bookmark_row_content.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <resources>	6 <resources>

7 <!-- Connection info popup dimensions -->	7 <!-- Connection info popup dimensions -->

8 <dimen name="connection_info_padding_wide">24dp</dimen>	8 <dimen name="connection_info_padding_wide">24dp</dimen>

9 <dimen name="connection_info_padding_thin">16dp</dimen>	9 <dimen name="connection_info_padding_thin">16dp</dimen>

10	10

(...skipping 299 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
310 <dimen name="custom_tabs_bottom_bar_max_height">60dp</dimen>	310 <dimen name="custom_tabs_bottom_bar_max_height">60dp</dimen>

311	311

312 <!-- Favicon dimensions -->	312 <!-- Favicon dimensions -->

313 <dimen name="default_favicon_size">16dp</dimen>	313 <dimen name="default_favicon_size">16dp</dimen>

314	314

315 <!-- Media UI dimensions -->	315 <!-- Media UI dimensions -->

316 <!-- The media_session_icon_size is just big enough to make sure Android doe sn't discard the	316 <!-- The media_session_icon_size is just big enough to make sure Android doe sn't discard the

317 icon but otherwise, the icon is meant to be a flat color so it doesn't really matter. -->	317 icon but otherwise, the icon is meant to be a flat color so it doesn't really matter. -->

318 <dimen name="media_session_icon_size">48dp</dimen>	318 <dimen name="media_session_icon_size">48dp</dimen>

319	319

320 <!-- Offline pages dimensions -->

321 <dimen name="offline_page_item_vertical_spacing">16dp</dimen>

322

323 <!-- Account chooser dialog dimensions -->	320 <!-- Account chooser dialog dimensions -->

324 <dimen name="account_chooser_dialog_margin">24dp</dimen>	321 <dimen name="account_chooser_dialog_margin">24dp</dimen>

325 <dimen name="account_chooser_dialog_item_margin">20dp</dimen>	322 <dimen name="account_chooser_dialog_item_margin">20dp</dimen>

326 <dimen name="account_chooser_dialog_title_main_text_size">18sp</dimen>	323 <dimen name="account_chooser_dialog_title_main_text_size">18sp</dimen>

327 <dimen name="account_chooser_dialog_title_descriptive_text_size">16sp</dimen >	324 <dimen name="account_chooser_dialog_title_descriptive_text_size">16sp</dimen >

328	325

329 <!-- Clear browsing data preferences dimensions -->	326 <!-- Clear browsing data preferences dimensions -->

330 <dimen name="clear_browsing_data_checkbox_height">56dp</dimen>	327 <dimen name="clear_browsing_data_checkbox_height">56dp</dimen>

331 </resources>	328 </resources>

OLD	NEW