Issue 18947002: Fix buildbot upload to commondatastorage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18947002: Fix buildbot upload to commondatastorage (Closed)

Created:
7 years, 5 months ago by Sam Clegg

Modified:
7 years, 5 months ago

Reviewers:
binji

CC:
native-client-reviews_googlegroups.com

Base URL:
https://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

Fix buildbot upload to commondatastorage. The buildbot masters now set BOTO_CONFIG and AWS_CREDENTIAL_FILE which was breaking the upload to nacl commondatastorage. BUG= R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1563

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	visual_studio/NativeClientVSAddIn/buildbot_run.py	View		1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

binji

lgtm https://codereview.chromium.org/18947002/diff/1/visual_studio/NativeClientVSAddIn/buildbot_run.py File visual_studio/NativeClientVSAddIn/buildbot_run.py (right): https://codereview.chromium.org/18947002/diff/1/visual_studio/NativeClientVSAddIn/buildbot_run.py#newcode185 visual_studio/NativeClientVSAddIn/buildbot_run.py:185: if 'BOTO_CONFIG' in os.environ: comment about why this ...

7 years, 5 months ago (2013-07-09 21:48:03 UTC) #2

Sam Clegg

7 years, 5 months ago (2013-07-09 21:52:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r1563 (presubmit successful).

Expand Messages | Collapse Messages