Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1894643002: Switch SkXfermodeImagerFilter over to new onFilterImage interface (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : Fix return values #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -90 lines) Patch
M include/effects/SkXfermodeImageFilter.h View 1 2 chunks +11 lines, -10 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 2 8 chunks +95 lines, -80 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
robertphillips
4 years, 8 months ago (2016-04-15 17:50:25 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894643002/20001
4 years, 8 months ago (2016-04-15 17:50:45 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/1996)
4 years, 8 months ago (2016-04-15 17:51:56 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894643002/40001
4 years, 8 months ago (2016-04-15 17:54:06 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 18:07:22 UTC) #12
Stephen White
LGTM Getting close!
4 years, 8 months ago (2016-04-15 19:13:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894643002/40001
4 years, 8 months ago (2016-04-15 19:46:47 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 19:47:45 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f230c6d979d7035cbf6995da8a0161e7802b92b7

Powered by Google App Engine
This is Rietveld 408576698