Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1894633002: Fix skiaserve crash when displaying batch bounds (Closed)

Created:
4 years, 8 months ago by Brian Osman
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix skiaserve crash when displaying batch bounds In my test case, the first actual batch would combine with the clear issued before auditing had been enabled. After the successful combine, we would try to inform the audit manager, but it didn't know about the batch, triggering an assert (and subsequent crash). Fix is ijust to ensure that no prior batches are pending when we turn on auditing. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1894633002 Committed: https://skia.googlesource.com/skia/+/1c9f9228e5dae355cbcdf6c4e6a10dc92ad6fe47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/debugger/SkDebugCanvas.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Brian Osman
4 years, 8 months ago (2016-04-15 17:37:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894633002/1
4 years, 8 months ago (2016-04-15 17:41:46 UTC) #5
jcgregorio
lgtm
4 years, 8 months ago (2016-04-15 17:49:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894633002/1
4 years, 8 months ago (2016-04-15 17:52:26 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 18:00:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1c9f9228e5dae355cbcdf6c4e6a10dc92ad6fe47

Powered by Google App Engine
This is Rietveld 408576698