Implement PersistentValueMap, a map that stores UniquePersistent values.

include/v8.h

Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index cfffc914b46f56593e5b97b6e6d09063e6118623..891c1e4735140a80cf214028f55a0758f5a2e2f5 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -140,6 +140,8 @@ class ObjectOperationDescriptor;
 class RawOperationDescriptor;
 class CallHandlerHelper;
 class EscapableHandleScope;
+template <typename T>
+class ReturnValue;
 
 namespace internal {
 class Arguments;
@@ -412,6 +414,8 @@ template <class T> class Local : public Handle<T> {
   template<class F> friend class internal::CustomArguments;
   friend class HandleScope;
   friend class EscapableHandleScope;
+  template <class F1, class F2, class F3>
+  friend class PersistentValueMap;
 
   V8_INLINE static Local<T> New(Isolate* isolate, T* that);
 };
@@ -527,7 +531,11 @@ template <class T> class PersistentBase {
       P* parameter,
       typename WeakCallbackData<S, P>::Callback callback);
 
-  V8_INLINE void ClearWeak();
+  template <typename P>
+  V8_INLINE P* ClearWeak();
+
+  // TODO(dcarney): remove this.
+  V8_INLINE void ClearWeak() { ClearWeak<void>(); }
 
   /**
    * Marks the reference to this object independent. Garbage collector is free
@@ -576,6 +584,8 @@ template <class T> class PersistentBase {
   template<class F> friend class UniquePersistent;
   template<class F> friend class PersistentBase;
   template<class F> friend class ReturnValue;
+  template <class F1, class F2, class F3>
+  friend class PersistentValueMap;
 
   explicit V8_INLINE PersistentBase(T* val) : val_(val) {}
   PersistentBase(PersistentBase& other); // NOLINT
@@ -781,6 +791,7 @@ class UniquePersistent : public PersistentBase<T> {
   template<class S>
   V8_INLINE UniquePersistent& operator=(UniquePersistent<S> rhs) {
     TYPE_CHECK(T, S);
+    this->Reset();
     this->val_ = rhs.val_;
     rhs.val_ = 0;
     return *this;
@@ -799,6 +810,106 @@ class UniquePersistent : public PersistentBase<T> {
   void operator=(UniquePersistent&);
 };
 
+typedef uintptr_t PersistentContainerValue;
+static const uintptr_t kPersistentContainerNotFound = 0;
+
+/**
+ * A map wrapper that allows using UniquePersistent as a mapped value.
+ * C++11 embedders don't need this class, as they can use UniquePersistent
+ * directly in std containers.
+ **/
+template <class K, class V, class Traits>
+class PersistentValueMap {
+ public:
+  V8_INLINE explicit PersistentValueMap(Isolate* isolate) : isolate_(isolate) {}
+
+  V8_INLINE ~PersistentValueMap() { Clear(); }
+
+  V8_INLINE Isolate* GetIsolate() { return isolate_; }
+
+  V8_INLINE size_t Size() { return Traits::Size(&impl_); }
+
+  V8_INLINE Local<V> Get(const K& key) {
+    return Local<V>::New(isolate_, FromVal(Traits::Get(&impl_, key)));
+  }
+
+  V8_INLINE bool Contains(const K& key) {
+    return Traits::Get(&impl_, key) != 0;
+  }
+
+  V8_INLINE bool SetReturnValueFrom(const K& key,

[dcarney, 2014/03/10 11:35:23]

just SetReturnValue

[vogelheim, 2014/03/10 19:00:46]

Done.

[vogelheim, 2014/03/10 19:00:46]

Done.

+                                    ReturnValue<Value>& returnValue);
+
+  V8_INLINE void SetReference(const K& key,
+                              const v8::Persistent<v8::Object>& parent) {
+    Persistent<V> persistent;
+    persistent.val_ = FromVal(Traits::Get(&impl_, key));
+    GetIsolate()->SetReference(parent, persistent);

[dcarney, 2014/03/10 11:35:23]

create a private function to take a raw pointer

[vogelheim, 2014/03/10 19:00:46]

Done.

That is, I'm reusing a private SetReference(..) overload.

+    persistent.val_ = 0;
+  }
+
+  UniquePersistent<V> Set(const K& key, Local<V> value) {

[dcarney, 2014/03/10 11:35:23]

this can't work, since the Set should 0 the unique, and if it didn't, you'd be
duplicating the cell and returning something that will necessarily destroy it

[vogelheim, 2014/03/10 19:00:46]

Not done.

(As discussed offline, the SetUnique returns a UniquePersistent of the old
value. That should be ok.)

+    UniquePersistent<V> persistent(isolate_, value);
+    return SetUnique(key, &persistent);
+  }
+
+  UniquePersistent<V> SetWithConfig(const K& key, Local<V> value,

[dcarney, 2014/03/10 11:35:23]

same here, plus this is not a very generic api

[vogelheim, 2014/03/10 19:00:46]

Kinda done. I've changed this to take a UniquePersistent, so that the caller can
set the class id/independent themselves. THis method then becomes an overload of
Set w/ a UniquePersistent.

Honestly, I'm not entirely sure if this is what you meant; please let me know if
not.

+                                    uint16_t classId, bool independent) {
+    UniquePersistent<V> persistent(isolate_, value);
+    persistent.SetWrapperClassId(classId);
+    if (independent) persistent.MarkIndependent();
+    return SetUnique(key, &persistent);
+  }
+
+  V8_INLINE UniquePersistent<V> Remove(const K& key) {
+    return Release(Traits::Remove(&impl_, key)).Pass();
+  }
+
+  /**
+  * Traverses the map repeatedly,
+  * in case side effects of disposal cause insertions.
+  **/
+  void Clear();
+
+ private:
+  PersistentValueMap(PersistentValueMap&);
+  void operator=(PersistentValueMap&);
+
+  UniquePersistent<V> SetUnique(const K& key, UniquePersistent<V>* persistent) {
+    if (Traits::kIsWeak) {
+      Local<V> value(Local<V>::New(isolate_, *persistent));
+      persistent->template SetWeak<typename Traits::WeakCallbackDataType>(
+          Traits::WeakCallbackParameter(&impl_, key, value), WeakCallback);
+    }
+    PersistentContainerValue old_value =
+        Traits::Set(&impl_, key, ClearAndLeak(persistent));
+    return Release(old_value).Pass();
+  }
+
+  static void WeakCallback(
+      const WeakCallbackData<V, typename Traits::WeakCallbackDataType>& data);
+  V8_INLINE static V* FromVal(PersistentContainerValue v) {
+    return reinterpret_cast<V*>(v);
+  }
+  V8_INLINE static PersistentContainerValue ClearAndLeak(
+      UniquePersistent<V>* persistent) {
+    V* v = persistent->val_;
+    persistent->val_ = 0;
+    return reinterpret_cast<PersistentContainerValue>(v);
+  }
+  V8_INLINE static UniquePersistent<V> Release(PersistentContainerValue v) {
+    UniquePersistent<V> p;
+    p.val_ = FromVal(v);
+    if (Traits::kIsWeak && !p.IsEmpty()) {
+      Traits::DisposeCallbackData(
+          p.template ClearWeak<typename Traits::WeakCallbackDataType>());
+    }
+    return p.Pass();
+  }
+
+  Isolate* isolate_;
+  typename Traits::Impl impl_;
+};
 
  /**
  * A stack-allocated class that governs a number of local handles.
@@ -4767,7 +4878,7 @@ class V8_EXPORT V8 {
   static void MakeWeak(internal::Object** global_handle,
                        void* data,
                        WeakCallback weak_callback);
-  static void ClearWeak(internal::Object** global_handle);
+  static void* ClearWeak(internal::Object** global_handle);
   static void Eternalize(Isolate* isolate,
                          Value* handle,
                          int* index);
@@ -5678,10 +5789,11 @@ void PersistentBase<T>::SetWeak(
   SetWeak<T, P>(parameter, callback);
 }
 
-
 template <class T>
-void PersistentBase<T>::ClearWeak() {
-  V8::ClearWeak(reinterpret_cast<internal::Object**>(this->val_));
+template <typename P>
+P* PersistentBase<T>::ClearWeak() {
+  return reinterpret_cast<P*>(
+      V8::ClearWeak(reinterpret_cast<internal::Object**>(this->val_)));
 }
 
 
@@ -5733,6 +5845,50 @@ uint16_t PersistentBase<T>::WrapperClassId() const {
   return *reinterpret_cast<uint16_t*>(addr);
 }
 
+template <class K, class V, class Traits>
+bool PersistentValueMap<K, V, Traits>::SetReturnValueFrom(
+    const K& key, ReturnValue<Value>& returnValue) {
+  PersistentContainerValue value = Traits::Get(&impl_, key);
+  if (value != 0) {
+    // TODO(vogelheim) Do I need to create that Handle? I didn't see a
+    //                 ReturnValue::Set without one.
+    returnValue.Set(Local<V>::New(isolate_, FromVal(value)));

[dcarney, 2014/03/10 11:35:23]

no new handle, just install it directly in return value

[vogelheim, 2014/03/10 19:00:46]

Done.

+    return true;
+  } else {
+    return false;
+  }
+}
+
+template <class K, class V, class Traits>
+void PersistentValueMap<K, V, Traits>::Clear() {
+  typedef typename Traits::Iterator It;
+  HandleScope handle_scope(isolate_);
+  // TODO(dcarney): figure out if this swap and loop is necessary.
+  while (!Traits::Empty(&impl_)) {
+    typename Traits::Impl impl;
+    Traits::Swap(impl_, impl);
+    for (It i = Traits::Begin(&impl); i != Traits::End(&impl); ++i) {
+      Traits::DisposeByKey(&impl, Traits::Key(i));
+      Traits::DisposeByValue(Release(Traits::Value(i)).Pass(), isolate_);
+    }
+  }
+}
+
+template <class K, class V, class Traits>
+void PersistentValueMap<K, V, Traits>::WeakCallback(
+    const WeakCallbackData<V, typename Traits::WeakCallbackDataType>& data) {
+  typename Traits::Impl* impl = Traits::ImplFromWeakCallbackData(data);
+  K key = Traits::KeyFromWeakCallbackData(data);
+  PersistentContainerValue value = Traits::Remove(impl, key);
+  // TODO(dcarney): this should be an const in Traits instead of kIsWeak.
+  if (data.GetValue().IsEmpty()) {  // Zombied handle.

[dcarney, 2014/03/10 11:35:23]

remove this clause

[vogelheim, 2014/03/10 19:00:46]

Done.

+    // TODO(dcarney): zombie callback/push on zombie queue.
+  } else {
+    Traits::DisposeByKey(impl, key);
+    Traits::DisposeByValue(Release(value).Pass(), data.GetIsolate());
+  }
+  Traits::DisposeCallbackData(data.GetParameter());
+}
 
 template<typename T>
 ReturnValue<T>::ReturnValue(internal::Object** slot) : value_(slot) {}