Issue 189463006: Fix license header for third_party/readability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 189463006: Fix license header for third_party/readability (Closed)

Created:
6 years, 9 months ago by benm (inactive)

Modified:
6 years, 9 months ago

Reviewers:
nyquist, Torne, mnaganov

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix license header for third_party/readability The format of the license field in third_party/readability/README.chromium makes the license checker erroneoulsy flag it as incompatible as it doesn't fit the regex. Android WebView is now depending on third_party/readability (another discussion perhaps) and there's no good reason to exclude it from the WebView build right now. TBR=nyquist@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255651

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	android_webview/tools/known_issues.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	third_party/readability/README.chromium	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/189463006/1

6 years, 9 months ago (2014-03-07 17:28:24 UTC) #4

Message was sent while issue was closed.

Change committed as 255651

Expand Messages | Collapse Messages