Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1894623002: No-op when trying to evaluate null string. (Closed)

Created:
4 years, 8 months ago by hush (inactive)
Modified:
4 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No-op when trying to evaluate null string. BUG=603756 Committed: https://crrev.com/f77c862645c2fb8d3d6eacc2c3d940f263454b46 Cr-Commit-Position: refs/heads/master@{#387692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
hush (inactive)
PTAL
4 years, 8 months ago (2016-04-15 17:19:31 UTC) #2
Ted C
lgtm
4 years, 8 months ago (2016-04-15 17:21:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894623002/1
4 years, 8 months ago (2016-04-15 18:29:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 20:30:16 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 20:31:56 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f77c862645c2fb8d3d6eacc2c3d940f263454b46
Cr-Commit-Position: refs/heads/master@{#387692}

Powered by Google App Engine
This is Rietveld 408576698