Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 1894593002: Adds WmLayoutManager and the aura wrapper AuraLayoutManagerAdapter (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds WmLayoutManager and the aura wrapper AuraLayoutManagerAdapter No tests as ash_unittests is going to end up testing this by virtue of converting some of the ash LayoutManagers to be WmLayoutManagers and installing on aura::Windows. BUG=603369 TEST=none R=jamescook@chromium.org Committed: https://crrev.com/d6078624276db684b84b6f1a3c9da536d05012c2 Cr-Commit-Position: refs/heads/master@{#387686}

Patch Set 1 #

Patch Set 2 : merge #

Total comments: 8

Patch Set 3 : merge and feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -0 lines) Patch
M ash/ash.gyp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A ash/wm/aura/aura_layout_manager_adapter.h View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
A ash/wm/aura/aura_layout_manager_adapter.cc View 1 chunk +51 lines, -0 lines 0 comments Download
A ash/wm/common/wm_layout_manager.h View 1 2 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
sky
4 years, 8 months ago (2016-04-15 16:37:26 UTC) #1
sky
This is relative to https://codereview.chromium.org/1890713002/ .
4 years, 8 months ago (2016-04-15 16:37:49 UTC) #2
sky
Now that other patch landed this is no longer relative.
4 years, 8 months ago (2016-04-15 17:13:40 UTC) #3
James Cook
LGTM with nits https://codereview.chromium.org/1894593002/diff/20001/ash/wm/aura/aura_layout_manager_adapter.h File ash/wm/aura/aura_layout_manager_adapter.h (right): https://codereview.chromium.org/1894593002/diff/20001/ash/wm/aura/aura_layout_manager_adapter.h#newcode19 ash/wm/aura/aura_layout_manager_adapter.h:19: // AuraLayoutManagerAdapter is an aura::LayoutManager that ...
4 years, 8 months ago (2016-04-15 17:44:35 UTC) #4
sky
https://codereview.chromium.org/1894593002/diff/20001/ash/wm/aura/aura_layout_manager_adapter.h File ash/wm/aura/aura_layout_manager_adapter.h (right): https://codereview.chromium.org/1894593002/diff/20001/ash/wm/aura/aura_layout_manager_adapter.h#newcode19 ash/wm/aura/aura_layout_manager_adapter.h:19: // AuraLayoutManagerAdapter is an aura::LayoutManager that calls to to ...
4 years, 8 months ago (2016-04-15 19:26:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894593002/40001
4 years, 8 months ago (2016-04-15 19:27:01 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-15 20:07:50 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 20:09:33 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d6078624276db684b84b6f1a3c9da536d05012c2
Cr-Commit-Position: refs/heads/master@{#387686}

Powered by Google App Engine
This is Rietveld 408576698