Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1894583002: [Layout API] Convert DragCaretController to use Document::layoutViewItem() (Closed)

Created:
4 years, 8 months ago by pilgrim_google
Modified:
4 years, 8 months ago
CC:
blink-reviews, chromium-reviews, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Convert DragCaretController to use Document::layoutViewItem() There was one reference to Document::layoutView() (clearSelection() method) which is deprecated by the new layout API. I converted it to use layoutViewItem() instead. No new API methods were required. There are no functional changes. BUG=499321 Committed: https://crrev.com/719023f01509d3e566668a8114a51be142ef5568 Cr-Commit-Position: refs/heads/master@{#387857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/DragCaretController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pilgrim_google
4 years, 8 months ago (2016-04-15 16:23:40 UTC) #2
eae
LGTM
4 years, 8 months ago (2016-04-17 18:16:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894583002/1
4 years, 8 months ago (2016-04-18 01:38:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 04:26:06 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 04:27:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/719023f01509d3e566668a8114a51be142ef5568
Cr-Commit-Position: refs/heads/master@{#387857}

Powered by Google App Engine
This is Rietveld 408576698