Move SkImageFilter over to storing sk_sps

Move SkImageFilter over to storing sk_sps

This CL also removes the old bare-pointer style ctor.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1894573002

Committed: https://skia.googlesource.com/skia/+/6b13473dd4d5915309cc2caddbab2e22f2f21d5f

[robertphillips, 2016-04-15 16:05:29]

Description was changed from

==========
Move SkImageFilter over to storing sk_sps
==========

to

==========
Move SkImageFilter over to storing sk_sps
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-15 16:28:55]

Description was changed from

==========
Move SkImageFilter over to storing sk_sps
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Move SkImageFilter over to storing sk_sps

This CL also removes the old bare-pointer style ctor.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-15 16:28:55]

robertphillips@google.com changed reviewers:
+ fmalita@chromium.org, reed@google.com

[robertphillips, 2016-04-15 16:29:20]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-15 16:29:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894573002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894573002/40001

[reed1, 2016-04-15 16:33:43]

lgtm

https://codereview.chromium.org/1894573002/diff/40001/include/core/SkImageFil...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1894573002/diff/40001/include/core/SkImageFil...
include/core/SkImageFilter.h:333: sk_sp<SkImageFilter>  getInput(int index)
const { return fInputs[index]; }
why does this getInput return sp, and the earlier one (up the this file) return
* ?

[commit-bot: I haz the power, 2016-04-15 16:44:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 16:44:33]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-15 16:56:05]

https://codereview.chromium.org/1894573002/diff/40001/include/core/SkImageFil...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1894573002/diff/40001/include/core/SkImageFil...
include/core/SkImageFilter.h:333: sk_sp<SkImageFilter>  getInput(int index)
const { return fInputs[index]; }
On 2016/04/15 16:33:43, reed1 wrote:
> why does this getInput return sp, and the earlier one (up the this file)
return
> * ?

Callers of this method intend to take a ref on the returned image filter.
Callers of the earlier accessor never do.

[robertphillips, 2016-04-15 16:57:35]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-04-15 16:57:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894573002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894573002/40001

[commit-bot: I haz the power, 2016-04-15 16:58:41]

Description was changed from

==========
Move SkImageFilter over to storing sk_sps

This CL also removes the old bare-pointer style ctor.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Move SkImageFilter over to storing sk_sps

This CL also removes the old bare-pointer style ctor.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6b13473dd4d5915309cc2caddbab2e22f2f21d5f
==========

[commit-bot: I haz the power, 2016-04-15 16:58:43]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6b13473dd4d5915309cc2caddbab2e22f2f21d5f

[reed1, 2016-04-15 17:08:51]

On 2016/04/15 16:56:05, robertphillips wrote:
>
https://codereview.chromium.org/1894573002/diff/40001/include/core/SkImageFil...
> File include/core/SkImageFilter.h (right):
> 
>
https://codereview.chromium.org/1894573002/diff/40001/include/core/SkImageFil...
> include/core/SkImageFilter.h:333: sk_sp<SkImageFilter>  getInput(int index)
> const { return fInputs[index]; }
> On 2016/04/15 16:33:43, reed1 wrote:
> > why does this getInput return sp, and the earlier one (up the this file)
> return
> > * ?
> 
> Callers of this method intend to take a ref on the returned image filter.
> Callers of the earlier accessor never do.

Understood, but doesn't seem clear from a reader looking at the file. Perhaps
rename the former to refInput(index) ?