Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1894523002: [turbofan] Introduce ObjectIsString operator. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce ObjectIsString operator. This adds an ObjectIsString operator and hooks it up with JSNativeContextSpecialization (to remove the use of some machine operators there). R=jarin@chromium.org Committed: https://crrev.com/2742b303b8e470689b41e0dad1c36ea49c7cc74b Cr-Commit-Position: refs/heads/master@{#35525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -9 lines) Patch
M src/compiler/change-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/change-lowering.cc View 2 chunks +23 lines, -2 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-15 11:56:32 UTC) #1
Jarin
lgtm.
4 years, 8 months ago (2016-04-15 12:04:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894523002/1
4 years, 8 months ago (2016-04-15 12:07:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 12:35:41 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 12:37:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2742b303b8e470689b41e0dad1c36ea49c7cc74b
Cr-Commit-Position: refs/heads/master@{#35525}

Powered by Google App Engine
This is Rietveld 408576698