Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1894513002: [turbofan] Mark escape analysis as experimental. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Mark escape analysis as experimental. This prefixes the escape analysis flag with "experimental", thereby making sure the flag in question is not being fuzzed. It will reduce noise levels on ClusterFuzz again. R=jarin@chromium.org BUG=chromium:603653 LOG=n Committed: https://crrev.com/58820332034e3a8d1ca6fbf6a8dc5fc51e4feb7d Cr-Commit-Position: refs/heads/master@{#35521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-10.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-3.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-4.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-5.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-6.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-7.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-8.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-9.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-deopt-1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-deopt-2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-deopt-3.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-deopt-4.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/escape-analysis-deopt-5.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-15 11:38:36 UTC) #1
Jarin
lgtm. Thanks!
4 years, 8 months ago (2016-04-15 11:59:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894513002/1
4 years, 8 months ago (2016-04-15 12:02:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 12:19:22 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 12:19:35 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/58820332034e3a8d1ca6fbf6a8dc5fc51e4feb7d
Cr-Commit-Position: refs/heads/master@{#35521}

Powered by Google App Engine
This is Rietveld 408576698